Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make login function's arguments required and not None #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sv0
Copy link

@sv0 sv0 commented May 28, 2024

This pull request:

  • moves arguments checking such as api_id, api_hash, api_phone_number to function main_entrypoint()
  • makes command line option --phone-numbers required

Rationale:

  • prepare a springboard for creating reusable pieces of code
    • e.g. I use this project as a library in pet-project(web based osint tool).

move arguments(api_id, api_hash, api_phone_number) checking
to function `main_entrypoint()`
Copy link
Contributor

@GalenReich GalenReich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, separating out functionality like this is really sensible! I think it would be good to preserve the interactive option, but it should definitely move into main_entrypoint as you've done with the other arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants