Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated documentation examples #23

Merged
merged 3 commits into from
May 31, 2024

Conversation

seehma
Copy link
Contributor

@seehma seehma commented May 30, 2024

newer TwinCAT versions require namespace access therefore added the namespace to all code examples

newer TwinCAT versions require namespace access therefore added the namespace to all code examples
Copy link
Owner

@bengeisler bengeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

With the latest release however, the namespace has changed to TcLogLib. Please update the PR.

Anyway, that release seems to solve #22 and #21, so maybe we'll just leave the docs as they are?

@seehma
Copy link
Contributor Author

seehma commented May 31, 2024

I updated the documentation. Of course its your choice how to deal with it, we install our libraries (Zeugwerk Framework) always with namespace required. Also Beckhoff often had problems on solving dependency things from libraries without namespace, sometimes it worked well, on some TwinCAT versions the compiler threw error messages. With Qualified access only, the problems were gone.
However, thanks for fixing it, i didnt had the time to take a closer look on it, my workaround with qualified access only was a quick fix :-)

@seehma seehma requested a review from bengeisler May 31, 2024 07:37
@bengeisler bengeisler merged commit 2243494 into bengeisler:main May 31, 2024
1 check failed
@seehma seehma deleted the doc-namespace branch May 31, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants