Fix crash for layer names with non-ascii characters #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes a crash that would occur if a layer name used non-ascii characters and
layerNameCStringwould becomeNULL.The C string will work as before for ASCII names, so this commit does not break compatibility. However, in the PSD spec I could not find any mention of how non-ascii layer names should be handled. It is entirely possible that this specific version of the file format did not support unicode layer names. Photoshop 2021 and its iPad counterpart seem to read layer names in a different encoding, but that could be because they are only working with what was available in the file spec PSDWriter uses. Procreate on the iPad reads unicode layer names without any issues.