Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added [[+position]] placeholder to support schema.org/BreadcrumbList #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

watou
Copy link

@watou watou commented Mar 27, 2019

In schema.org/BreadcrumbList, each element in the breadcrumb list has the required property position, to indicate the depth of the item in the breadcrumb list. Example:

<ol itemscope itemtype="http://schema.org/BreadcrumbList">
  <li itemprop="itemListElement" itemscope
      itemtype="http://schema.org/ListItem">
    <a itemprop="item" href="https://example.com/dresses">
    <span itemprop="name">Dresses</span></a>
    <meta itemprop="position" content="1" />
  </li>
  <li itemprop="itemListElement" itemscope
      itemtype="http://schema.org/ListItem">
    <a itemprop="item" href="https://example.com/dresses/real">
    <span itemprop="name">Real Dresses</span></a>
    <meta itemprop="position" content="2" />
  </li>
</ol>

The MODX addon does not support this without adding the [[+position]] placeholder (this PR). The docs etc. would have to be updated as well.

Signed-off-by: John Cocula [email protected]

@JoshuaLuckers
Copy link

@benjamin-vauchel do you still maintain this extra? If not, would you mind if someone else adopts it?

@JoshuaLuckers
Copy link

@benjamin-vauchel I merged your PR in my own fork and released it as an update for the BreadCrumbs extra! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants