fix critical js error in some case #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,7 @@ var Dailymotion = (function (_Tech) { | |||
|
|
|||
| if (typeof this.videoId !== 'undefined') { | |||
| this.setTimeout(function () { | |||
| _this.setPoster('//api.dailymotion.com/video/' + _this.videoId + '?fields=poster_url&ads=false'); | |||
| _this.setPoster('https://api.dailymotion.com/video/' + _this.videoId + '?fields=thumbnail_large_url'); | |||
There was a problem hiding this comment.
I think it'll be better to stick to //api. rather than enforcing https://, that way it'll ensure compatibility from all sort of requests. Don't you think so?
|
the api doesn't work with http protocol, only https |
| this.poster_ = poster; | ||
| this.trigger('posterchange'); | ||
| var baseClass = this; | ||
| $.getJSON(poster, function(data) { |
There was a problem hiding this comment.
Use Videojs get instead if jquey
videojs.xhr({
-
body: someJSONString, -
uri: "/foo", -
headers: { -
"Content-Type": "application/json" -
} -
}, function (err, resp, body) { -
// check resp.statusCode -
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is 1 improvement (poster is now correctly loaded using ajax with jquery)
and 1 bug fix, in some case loadApi() is called but the iframe still doesn't exists yet, this cause a fatal error (from dailymotion js) and avoid any further js to work on the page