Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Swift Package Manager / Atomics #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ralph-e-boy
Copy link
Contributor

No description provided.

@ralph-e-boy
Copy link
Contributor Author

think I broke the project file tho

@ralph-e-boy
Copy link
Contributor Author

@mvyrko can you test this?

@benski
Copy link
Owner

benski commented Nov 11, 2020

thanks @ralph-e-boy!!! I will take a look at this tonight

}

func async(_ block: @escaping dispatch_block_t_swift) {
perform(Selector(("runBlock:")),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point I had this in Swift. I was getting intermittent memory failures, though, and moved it back to ObjC. I'll dig up the commit and see if I can remember why.

That said, Realm 5 finally introduced Queue-specific realm objects in addition to the Thread-specific realm objects, so my primary need for all this thread nonsense could go away soon.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the commit where I had stopped using Swift for this. I think that the Swift compiler was doing the wrong thing with block and leading to occasional memory failures (use after release)
a13148e

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be fixed now with swift 5.3? Release notes mention runtime memory improvements.
Fixed the project file!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants