Skip to content

Commit

Permalink
Merge pull request #102 from bestlong/deps-and-linting
Browse files Browse the repository at this point in the history
Update depenedencies and linting
  • Loading branch information
Steve-Mcl authored Aug 31, 2024
2 parents 25e63b4 + 953f3e0 commit 75687c0
Show file tree
Hide file tree
Showing 6 changed files with 638 additions and 639 deletions.
22 changes: 8 additions & 14 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,20 @@ module.exports = {
es2021: true
},
extends: [
'eslint:recommended',
'standard'
],
globals: {
RED: true,
Promise: true
},
plugins: ['eslint-plugin-html', 'no-only-tests'],
parserOptions: {
ecmaVersion: 13
},
rules: {
indent: ['error', 4],
semi: ['error', 'always'],
quotes: ['error', 'single', { avoidEscape: true, allowTemplateLiterals: true }],
'quote-props': ['error', 'as-needed', { unnecessary: false }]
// 'space-before-function-paren': ['never'],
// 'spaced-comment': ['never']

},
plugins: [
'html'
],
settings: {
'html/html-extensions': ['.html']
'spaced-comment': ['error', 'always', { block: { balanced: true }, line: { markers: ['/'] } }],
'no-only-tests/no-only-tests': 'error'
}

};
}
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

strategy:
matrix:
node-version: [16, 18]
node-version: [16, 18, 20]

env:
SA_PASSWORD: "P@ssw0rdP@ssw0rd"
Expand Down Expand Up @@ -66,5 +66,9 @@ jobs:
cp ./test/_config.github.json ./test/config.json
npm install
- name: Run ESLint
if: matrix.node-version == 20
run: npm run lint

- name: npm test
run: npm test
23 changes: 12 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,18 @@
"description": "A node-red node to execute queries, stored procedures and bulk inserts in Microsoft SQL Server and Azure Databases SQL2000 ~ SQL2022",
"main": "odbc.js",
"dependencies": {
"mssql": "^10.0.0",
"mssql": "^10.0.4",
"mustache": "^4.2.0"
},
"devDependencies": {
"eslint": "^7.25.0",
"eslint-config-standard": "^16.0.2",
"eslint-plugin-html": "^6.1.2",
"eslint-plugin-import": "^2.22.1",
"eslint": "^8.47.0",
"eslint-config-standard": "^17.1.0",
"eslint-plugin-html": "^7.1.0",
"eslint-plugin-no-only-tests": "^3.3.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^4.3.1",
"mocha": "^9.2.0",
"node-red": "^1.0.3",
"node-red-node-test-helper": "^0.3.0",
"mocha": "^10.7.3",
"node-red": "^4.0.2",
"node-red-node-test-helper": "^0.3.4",
"should": "^13.2.3"
},
"node-red": {
Expand All @@ -34,6 +33,8 @@
},
"scripts": {
"test": "mocha \"test/**/*_spec.js\"",
"lint": "eslint test/**/*.js src/**/*.js src/**/*.html",
"lint:fix": "eslint test/**/*.js src/**/*.js src/**/*.html --fix",
"release": "np"
},
"repository": {
Expand All @@ -54,8 +55,8 @@
"author": "Redconnect.io",
"contributors": [
"Shao Yu-Lung <[email protected]> (https://github.com/bestlong)",
"Olli Kasari <8488349+kasarol@users.noreply.github.com>",
"Steve McLaughlin <44235289+Steve-Mcl@users.noreply.github.com> (https://github.com/Steve-Mcl)"
"Steve McLaughlin <44235289+Steve-Mcl@users.noreply.github.com> (https://github.com/Steve-Mcl)",
"Olli Kasari <8488349+kasarol@users.noreply.github.com>"
],
"license": "MIT",
"homepage": "https://github.com/bestlong/node-red-contrib-mssql-plus",
Expand Down
Loading

0 comments on commit 75687c0

Please sign in to comment.