Only keep release artifacts for one day #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Apr 28, 2023
idanarye
force-pushed
the
only-keep-release-artifacts-for-one-day
branch
from
bdb9ac3 to
5b4d75e
Compare
alice-i-cecile
approved these changes
Sep 20, 2023
idanarye
force-pushed
the
only-keep-release-artifacts-for-one-day
branch
from
5b4d75e to
63f6eed
Compare
|
@ameknite can I get your review here? |
ameknite
approved these changes
Sep 20, 2023
mockersf
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default artifacts are retained for three months. Considering how the only thing that looks at them is the
upload-to-itchjob, which will run immediately after, this seems wasteful. One day is enough (we probably don't even need a whole day, but that's the minimum)