This repository was archived by the owner on Apr 13, 2021. It is now read-only.
fix: Assert that the comparison process depending of external node ap… #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plications executes OK.
Tests:
laravel-visual-diff/src/VisualDiff.php
Lines 133 to 139 in fbf586f
I'm not sure I can add tests, as I cannot replace Process here, it's being instatiated with
new
keyword,I would go ahead and resolve it with container, but let's see what you have to say?
This would be equivalent
and then we could swap out in the test.
So, in manual testing...
When running
php artisan dusk
, and notpngjs
installedoutput is
Then, next, without
pixelmatch
installedThen, when both are installed...
So, what do you think?