Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aave Swapper: Limit Orders #201

Closed
wants to merge 17 commits into from
Prev Previous commit
Next Next commit
feat: add tests to cancel limit orders
efecarranza committed Dec 18, 2023
commit bb2e2aab3a33baf2a6a15331d8829ddf01b04120
91 changes: 91 additions & 0 deletions tests/swaps/AaveSwapperTest.t.sol
Original file line number Diff line number Diff line change
@@ -634,3 +634,94 @@ contract LimitSwap is AaveSwapperTest {
vm.stopPrank();
}
}

contract CancelLimitSwap is AaveSwapperTest {
function setUp() public override {
vm.createSelectFork(vm.rpcUrl('mainnet'), 18815161);

vm.startPrank(AaveGovernanceV2.SHORT_EXECUTOR);
swaps = new AaveSwapper();
vm.stopPrank();
}

function test_revertsIf_invalidCaller() public {
uint256 amount = 1_000e18;
vm.expectRevert('ONLY_BY_OWNER_OR_GUARDIAN');
swaps.cancelLimitSwap(
makeAddr('milkman-instance'),
LIMIT_ORDER_PRICE_CHECKER,
AaveV2EthereumAssets.WETH_UNDERLYING,
AaveV2EthereumAssets.AAVE_UNDERLYING,
address(AaveV2Ethereum.COLLECTOR),
amount,
amount
);
}

function test_revertsIf_noMatchingTrade() public {
deal(AaveV2EthereumAssets.AAVE_UNDERLYING, address(swaps), 1_000e18);
vm.startPrank(AaveGovernanceV2.SHORT_EXECUTOR);
swaps.limitSwap(
MILKMAN,
LIMIT_ORDER_PRICE_CHECKER,
AaveV2EthereumAssets.AAVE_UNDERLYING,
AaveV2EthereumAssets.USDC_UNDERLYING,
address(AaveV2Ethereum.COLLECTOR),
1_000e18,
1_000e18
);

vm.expectRevert();
swaps.cancelLimitSwap(
makeAddr('not-milkman-instance'),
LIMIT_ORDER_PRICE_CHECKER,
AaveV2EthereumAssets.AAVE_UNDERLYING,
AaveV2EthereumAssets.USDC_UNDERLYING,
address(AaveV2Ethereum.COLLECTOR),
1_000e18,
1_000e18
);
vm.stopPrank();
}

function test_successful() public {
deal(AaveV2EthereumAssets.AAVE_UNDERLYING, address(swaps), 1_000e18);
vm.startPrank(AaveGovernanceV2.SHORT_EXECUTOR);

vm.expectEmit(true, true, true, true);
emit LimitSwapRequested(
MILKMAN,
AaveV2EthereumAssets.AAVE_UNDERLYING,
AaveV2EthereumAssets.USDC_UNDERLYING,
1_000e18,
address(AaveV2Ethereum.COLLECTOR),
1_000e18
);
swaps.limitSwap(
MILKMAN,
LIMIT_ORDER_PRICE_CHECKER,
AaveV2EthereumAssets.AAVE_UNDERLYING,
AaveV2EthereumAssets.USDC_UNDERLYING,
address(AaveV2Ethereum.COLLECTOR),
1_000e18,
1_000e18
);

vm.expectEmit();
emit SwapCanceled(
AaveV2EthereumAssets.AAVE_UNDERLYING,
AaveV2EthereumAssets.USDC_UNDERLYING,
1_000e18
);
swaps.cancelLimitSwap(
0x524c7Dfc9fEd2C68fAcBfA2aBF8aD58fd6fdb408, // Address generated by tests
LIMIT_ORDER_PRICE_CHECKER,
AaveV2EthereumAssets.AAVE_UNDERLYING,
AaveV2EthereumAssets.USDC_UNDERLYING,
address(AaveV2Ethereum.COLLECTOR),
1_000e18,
1_000e18
);
vm.stopPrank();
}
}