Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Participants data always null. Issue 49 never thrown. #1772

Closed
wants to merge 4 commits into from
Closed

[WIP] Participants data always null. Issue 49 never thrown. #1772

wants to merge 4 commits into from

Commits on Aug 8, 2023

  1. All because I won't rewrite history... Revert "Revert "participants g… 

    …ets reassigned, declare with let not const""

This reverts commit 5ec0b3d.
    @rwblair
    rwblair committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0b21f8c View commit details
    Browse the repository at this point in the history

  2. maybe theres a reason why all the other ones are consts. Lets do what… 

    … they do and use Object assign
    @rwblair
    rwblair committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cf46045 View commit details
    Browse the repository at this point in the history

  3. better default assignment for participants and update logic in subjec… 

    …t tests in case there is no participants file
    @rwblair
    rwblair committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4c64e56 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. Merge branch 'master' into fix/participants_not_stored

    @effigies
    effigies authored Nov 12, 2023
    Configuration menu
    Copy the full SHA
    c838065 View commit details
    Browse the repository at this point in the history