Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass event data through to getValuesForElement #1460

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dararish
Copy link

Resolves issue #1189

@dararish
Copy link
Author

I don't see how the evaluation in the Function call can access the values parameter at all. Does that need to be fixed too or am I missing something?

@andsip
Copy link

andsip commented Feb 15, 2024

If this change would be ready to merge, i.e. if it doesn't break any other behavior, I think it would be a good one, as relying on the global window.event is relying on a deprecated property.

@janisint
Copy link

I would also appreciate if this got merged since I am affected by this issue

@Telroshan Telroshan added the enhancement New feature or request label Mar 3, 2024
@aliml92
Copy link

aliml92 commented Mar 18, 2024

me too waiting this to be merged

@Telroshan Telroshan added bug Something isn't working and removed enhancement New feature or request labels Dec 16, 2024
@Telroshan
Copy link
Collaborator

Hey, following up very late on this sry, are you still interested in this change @dararish ?
If so, could you please

  • Rebase to dev and resolve conflicts as the lib has been through quite some changes since then
  • Add a test case for this issue (make sure it fails with the current lib, then succeeds with your fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs rebase/retarget needs test PR needs a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants