Typo in addEventListener - use evt instead of event #3188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
addEventListener
, when thetriggerSpec.changed
if block was entered,node
was being set toevent.target
. This technically works, but is deprecated and should useevt.target
instead like the rest ofaddEventListener
.Corresponding issue: #3179
Testing
Smoke test a basic changed trigger flow.
/hello
should get called as expected (meaning thatnode
, and thusnode.value
are still getting assigned as expected):Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded