[FIX] OWLearnerWidget: Don't crash when no features #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.61%@@ master #1389 diff @@
==========================================
Files 75 75
Lines 7460 7460
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6536 6536
Misses 924 924
Partials 0 0
|
| @@ -186,6 +186,9 @@ def check_data(self): | |||
| self.error(self.DATA_ERROR_ID, | |||
| "Data contains a single target value. " | |||
| "There is nothing to learn.") | |||
| elif self.data.X.size == 0: | |||
| self.error(self.DATA_ERROR_ID, | |||
| "Found array with 0 feature(s) while a minimum of 1 is required.") | |||
There was a problem hiding this comment.
"Data has no features to learn from."? Zero features are plural. 😛
There was a problem hiding this comment.
I was being sloppy and just copied the error from scikit 🙈 Corrected.
If we provide a data set without any features (as unpreprocessed Corspus) learners crashed with a red screen. This PR adds a check for this and shows an error message instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we provide a data set without any features (as unpreprocessed Corspus) learners crashed with a red screen. This PR adds a check for this and shows an error message instead.