[ENH] Impute widget: Parallel execution in the background #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
impute-widget-threading
branch
from
ec6a1d5 to
51f46d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2395 +/- ##
==========================================
- Coverage 74.66% 74.33% -0.34%
==========================================
Files 320 321 +1
Lines 56225 56235 +10
==========================================
- Hits 41979 41800 -179
- Misses 14246 14435 +189 |
ales-erjavec
force-pushed
the
impute-widget-threading
branch
4 times, most recently
from
7503f5a to
9a04f11
Compare
ales-erjavec
changed the title
ales-erjavec
force-pushed
the
impute-widget-threading
branch
2 times, most recently
from
77ea616 to
ef416b3
Compare
ales-erjavec
force-pushed
the
impute-widget-threading
branch
3 times, most recently
from
e96ab80 to
55d06b8
Compare
The learner input requires that the single instance of `impute.Model` be modified in place for the changes to take effect.
ales-erjavec
force-pushed
the
impute-widget-threading
branch
from
c5765ba to
0766f46
Compare
|
Great, thanks! Model based imputation on adult is now 30s instead of 55s on my machine (one variable takes more time than others). Average imputation of GDS2808 is now 140s instead of 400s + computation can be interrupted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Imputer widget blocks the main GUI thread.
Description of changes
Move the column imputer fitting into background thread[s].
Includes