Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWTable: Include attributes from meta attributes in header row labels #3633

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 1, 2019

Issue

Fixes #2777

Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the owtable-meta-attr-labels branch from 07ddbf9 to 035666d Compare March 1, 2019 15:16
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #3633 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3633      +/-   ##
==========================================
+ Coverage   84.31%   84.32%   +<.01%     
==========================================
  Files         370      370              
  Lines       67838    67850      +12     
==========================================
+ Hits        57197    57213      +16     
+ Misses      10641    10637       -4

@markotoplak
Copy link
Member

This is certainly a fix of the point (2) in #2777.

But you decided that you won't fix the point (1), right?

@markotoplak markotoplak changed the title OWTable: Include attributes from meta attributes in header row labels [FIX] OWTable: Include attributes from meta attributes in header row labels Mar 5, 2019
@markotoplak markotoplak merged commit 0cb6f0e into biolab:master Mar 5, 2019
@janezd
Copy link
Contributor Author

janezd commented Mar 5, 2019

I didn't decide, I just overlooked it. :)

But if I didn't overlook it, I still wouldn't implement it. I think it doesn't hurt to have this information there. If we however decide to remove it, we can easily do this by renaming "color" to "_color".

What's your opinion? And @BlazZupan, @brunap, others?

@markotoplak
Copy link
Member

@janezd, I am against hiding "color". I have no opinion about "_color".

@janezd
Copy link
Contributor Author

janezd commented Mar 5, 2019

If you're against hiding, that's it. We would rename it to _color if we wanted to hide it -- all attributes that start with _ are automatically hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants