[ENH] WebviewWidget: expose JavaScript timeout limit #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need for #60. |
Codecov Report
@@ Coverage Diff @@
## master #3811 +/- ##
==========================================
+ Coverage 85.06% 85.06% +<.01%
==========================================
Files 374 374
Lines 69142 69143 +1
==========================================
+ Hits 58816 58817 +1
Misses 10326 10326 |
janezd
reviewed
May 24, 2019
Orange/widgets/utils/webview.py
Outdated
| @@ -535,7 +535,7 @@ def is_all_exposed(self): | |||
| class WebviewWidget(_WebViewBase, WebEngineView): | |||
| _html = _NOTSET | |||
|
|
|||
| def __init__(self, parent=None, bridge=None, *, debug=False, **kwargs): | |||
| def __init__(self, parent=None, bridge=None, js_timeout=5000, *, debug=False, **kwargs): | |||
There was a problem hiding this comment.
I'd prefer *, js_timeout=5000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Widgets based on WebviewWidget have no options to change the timeout limit for running JavaSript code.
Description of changes
Expose a new js_timeout parameter.
Includes