[FIX] relief: Fix contingency (de)allocation #4745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
_contingency_table
in relief.pyx does not retain np.ndarray allocated data buffer after function returns even though it 'inserts' a cython MemoryView into a c++ std::map, which is then used later (I think MemoryView cannot be readily inserted in c++ std containers and preserve referential integrity).This can lead to a segfault or memory corruption. It can be triggered on macOS with
Description of changes
Use Dict[int, np.ndarray] instead of std::map[ssize_t, MemoryView] as 'contingencies'. Acquire GIL when necessary when accessing elements.
Includes