Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add noReactDeps #5219

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

fireairforce
Copy link
Member

Summary

WIP

Test Plan

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Mar 1, 2025
@fireairforce fireairforce force-pushed the support-no-react-deps branch from 31adde6 to dc4ae2c Compare March 3, 2025 06:01
@github-actions github-actions bot added the A-CLI Area: CLI label Mar 3, 2025
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #5219 will degrade performances by 17%

Comparing support-no-react-deps (becee98) with main (f49003a)

Summary

❌ 7 regressions
✅ 88 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
js_analyzer[css_16118272471217147034.js] 19.3 ms 22.1 ms -12.42%
js_analyzer[index_3894593175024091846.js] 47.8 ms 54.6 ms -12.49%
js_analyzer[lint_13640784270757307929.ts] 36.9 ms 40.6 ms -9.24%
js_analyzer[parser_13571644119461115204.ts] 68.2 ms 79 ms -13.7%
js_analyzer[router_17129688031671448157.ts] 20.2 ms 24.3 ms -17%
js_analyzer[statement_263793315104667298.ts] 65.6 ms 77.5 ms -15.34%
js_analyzer[typescript_3735799142832611563.ts] 105.3 ms 126.3 ms -16.66%

@fireairforce fireairforce force-pushed the support-no-react-deps branch from db59324 to fb68954 Compare March 17, 2025 09:31
@fireairforce fireairforce force-pushed the support-no-react-deps branch from fb68954 to becee98 Compare March 17, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant