Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement noPrivateImports #5395

Closed
wants to merge 4 commits into from

Conversation

siketyan
Copy link
Member

Summary

Continues #5388

Test Plan

Snapshot tests added.

@siketyan siketyan self-assigned this Mar 19, 2025
@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Mar 19, 2025
@siketyan siketyan force-pushed the no-private-imports branch from 477e71f to ed16c70 Compare March 19, 2025 16:12
Copy link

codspeed-hq bot commented Mar 19, 2025

CodSpeed Performance Report

Merging #5395 will not alter performance

Comparing siketyan:no-private-imports (40b9b79) with main (31b6870)

Summary

✅ 95 untouched benchmarks

@arendjr
Copy link
Contributor

arendjr commented Mar 19, 2025

Thanks so much! I've pushed all your commits into my WIP: #5388

@arendjr arendjr closed this Mar 19, 2025
@siketyan siketyan deleted the no-private-imports branch March 19, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants