refactor(lint): a11y utils to reduce duplicate function definitions #5405
+72
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #5405 will not alter performanceComparing Summary
|
unvalley
commented
Mar 21, 2025
Comment on lines
+101
to
+104
| // Custom components are not checked because we do not know what DOM will be used. | ||
| if node.is_custom_component() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
noStaticElementInteractions explicitly skip custom components. Test fails without this change.
ematipico
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several a11y lint rules currently define similar functions independently.
This PR changes them to use a single consolidated implementation.
And explicitly skip linting to custom components in
noStaticElementInteractions.Test Plan
Existing tests should pass.