Add opentelemetry support #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,12 @@ | |||
| "REQUEST_MAX_SIZE": 100000000, | |||
| "CACHE_MAX_AGE": 604800 | |||
| }, | |||
| "opentelemetry": { | |||
| "OPENTELEMETRY_ENABLED": false, | |||
There was a problem hiding this comment.
Cool to have the default values here.
We could just enable the OPTL in the Dockerfile as an ENV variable
ENV OPENTELEMETRY_ENABLED True
| @@ -7,6 +7,12 @@ | |||
| "REQUEST_MAX_SIZE": 100000000, | |||
| "CACHE_MAX_AGE": 604800 | |||
| }, | |||
| "opentelemetry": { | |||
| "OPENTELEMETRY_ENABLED": false, | |||
| "OPENTELEMETRY_SERVICE_NAME": "biothings-annotator", | |||
There was a problem hiding this comment.
Did you confirm the Service Name to Chunlei? If it's different from "biothings-annotator", the ENV variable OPENTELEMETRY_SERVICE_NAME could be added to the Dockerfile.
| "opentelemetry-exporter-otlp >= 1.28.2", | ||
| "opentelemetry.exporter.jaeger.thrift >= 1.21.0", | ||
| "opentelemetry-instrumentation >= 0.49b2" | ||
| ] |
There was a problem hiding this comment.
Hey @ctrl-schaff, while running the branch locally, there is the error below. It seems the library just needs to be installed. However, they are here to be installed.
ModuleNotFoundError: No module named 'opentelemetry'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.