This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Sync up with changes from voting branch #15
Merged
+547
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate persistence by domains via custom services (See: bisq-network#8) - Add AppendOnlyDataStoreService and ProtectedDataStoreService - Improve handling of reading from resource files - Rename getHash to get32ByteHash - Add getCompactHash (20 bytes) - Add resource files, remove old persistableNetworkPayloadMap
sqrrm
reviewed
Jul 9, 2018
| transferDeprecatedDataStructure(); | ||
| } | ||
|
|
||
| private void transferDeprecatedDataStructure() { |
There was a problem hiding this comment.
I haven't tested this locally since I always run from a fresh setup. What are the possible issues if this fails?
There was a problem hiding this comment.
That users request all persisted data (account witness and trade statsistics) from seed node once after update. If it works at intended (and tested) the old map is used to be converted to the new data objects and then the old gets deleted. So the seed nodes dont get any extra load.
|
ACK - see bisq-network/bisq#1601 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been several changes in the voting branch (and api-integration) which I want to get into master to avoid that those branches run out of sync as well as to apply the improvements.
The main changes are:
Beside that there are many smaller trivial improvements, fixes, refactoring and cleanups.
Changes in that project:
Change data persitence #8)