Skip to content

Commit

Permalink
fix!: Disabled by default auto-remove rules Free inodes and Free space
Browse files Browse the repository at this point in the history
For newly created profiles, the two auto-remove rules regarding free inodes and free space are disabled by default.

Related to #1976
  • Loading branch information
buhtz authored Dec 31, 2024
1 parent 460a414 commit 350274e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Version 1.6.0-dev (development of upcoming release)
* Fix: Crash when comparing a snapshot with a symlink pointing to a nonexistent target (Peter Sevens @sevens)
* Fix: Crash (KeyError) opening language setup dialog with unknown locale/language
* Changed: Completed license information to conform the REUSE.software and SPDX standards.
* Breaking Change: Auto-remove rules "Free inodes" and "Free space" disabled by default (#1976)

Version 1.5.3 (2024-11-13)
* Doc: User manual (build with MkDocs) (#1838) (Kosta Vukicevic @stcksmsh)
Expand Down
4 changes: 2 additions & 2 deletions common/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ def minFreeSpace(self, profile_id = None):
self.profileIntValue('snapshots.min_free_space.unit', self.DISK_UNIT_GB, profile_id))

def minFreeSpaceEnabled(self, profile_id = None):
return self.profileBoolValue('snapshots.min_free_space.enabled', True, profile_id)
return self.profileBoolValue('snapshots.min_free_space.enabled', False, profile_id)

def minFreeSpaceMib(self, profile_id = None):
enabled, value, unit = self.minFreeSpace(profile_id)
Expand Down Expand Up @@ -1014,7 +1014,7 @@ def minFreeInodes(self, profile_id = None):
def minFreeInodesEnabled(self, profile_id = None):
#?Remove snapshots until \fIprofile<N>.snapshots.min_free_inodes.value\fR
#?free inodes in % is reached.
return self.profileBoolValue('snapshots.min_free_inodes.enabled', True, profile_id)
return self.profileBoolValue('snapshots.min_free_inodes.enabled', False, profile_id)

def setMinFreeInodes(self, enabled, value, profile_id = None):
self.setProfileBoolValue('snapshots.min_free_inodes.enabled', enabled, profile_id)
Expand Down
4 changes: 2 additions & 2 deletions common/man/C/backintime-config.1
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ Type: bool Allowed Values: true|false
.br
Remove snapshots until \fIprofile<N>.snapshots.min_free_inodes.value\fR free inodes in % is reached.
.PP
Default: true
Default: false
.RE

.IP "\fIprofile<N>.snapshots.min_free_inodes.value\fR" 6
Expand All @@ -399,7 +399,7 @@ Type: bool Allowed Values: true|false
.br
Remove snapshots until \fIprofile<N>.snapshots.min_free_space.value\fR free space is reached.
.PP
Default: true
Default: false
.RE

.IP "\fIprofile<N>.snapshots.min_free_space.unit\fR" 6
Expand Down

0 comments on commit 350274e

Please sign in to comment.