Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing debug-info on paths when backup path structure does not exist #1941

Closed
igor-karpekin opened this issue Nov 21, 2024 · 6 comments · Fixed by #1975
Closed

Missing debug-info on paths when backup path structure does not exist #1941

igor-karpekin opened this issue Nov 21, 2024 · 6 comments · Fixed by #1975
Labels
Feedback needs user response, may be closed after timeout without a response GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues Logging & diagnostics

Comments

@igor-karpekin
Copy link

igor-karpekin commented Nov 21, 2024

Hello,
I had to configure everything from terminal - no UI. It took me a few hours to construct the necessary path for backups because of very confusing docs and lack of my understanding of the app. Can you please add the erroneous backup target path into debug output? Currently that is how it looks:

notify-send -t 30000 Back In Time (admin) : daily Can't find snapshots folder. If it is on a removable drive please plug it. Waiting 30 seconds.
Failed to execute child process “dbus-launch” (No such file or directory)
DEBUG: [common/snapshots.py:747 backup] Cannot start snapshot yet: target directory not accessible. Waiting 1s.

Please add the full path in the error message that caused the error, that is a simple change, but can help a lot, e.g:

notify-send -t 30000 Back In Time (admin) : daily Can't find snapshots folder '/backup/backintime/myserver/root/1'. If it is on a removable drive please plug it. Waiting 30 seconds.

Thanks,
Igor.

@buhtz
Copy link
Member

buhtz commented Nov 22, 2024

Hello Igor,

Thank you for taking the time to report the issue and providing the details. I appreciate your feedback, will investigate the issue.
Your suggestion is IMHO a good solution.

Which version of BIT are you using?

About the docu and config file? Yes, that is far a away from optimal. We have several issues and todo-task open and pending about that topic. One is that I do plan to convert the current config file format into a TOML file which is IMHO easier to read for human beings.

If you have any more details or ideas to share, feel free to reach out.

Not sure when we'll find the time to work on it. Please see the projects background information to get an idea about our workflow and priorities:

Best regards,
Christian

@buhtz buhtz added Feature requests a new feature Bug Logging & diagnostics labels Nov 22, 2024
@buhtz buhtz added this to the 1.6.0 (upcoming release) milestone Nov 22, 2024
@buhtz buhtz added GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues and removed Feature requests a new feature Bug labels Nov 22, 2024
@buhtz buhtz changed the title missing info on paths when backup path structure does not exist Missing debug-info on paths when backup path structure does not exist Nov 22, 2024
@s4moore
Copy link
Contributor

s4moore commented Dec 8, 2024

Hello, I am searching for my first issue and came across this.

If I understand the problem correctly, couldn't this be achieved by simply changing common/snapshots.py 828 > 829 from:

message = (
    _("Can't find snapshots directory.\n"

to:

message = (
    _(f"Can't find snapshots directory '{self.snapshotsFullPath(profile_id)}'.\n"

@buhtz
Copy link
Member

buhtz commented Dec 20, 2024

Hello Samuel,
yes, you are right. Would you like to jump in and provide a PR?

I would suggest a minor modification to your solution because our translators might not understand that string (see our doc about translatable strings):

message = (
_(f"Can't find snapshots directory '{path}'.\n")
.format(path=self.snapshotsFullPath(profile_id)

We can work further on this if you open a PR.

Thanks in advance,
Christian

@buhtz buhtz added the Feedback needs user response, may be closed after timeout without a response label Dec 20, 2024
@s4moore
Copy link
Contributor

s4moore commented Dec 21, 2024

Thank you, I have submitted a PR (#1975)

@vinothk-master
Copy link

Hi @buhtz
Is this issue fixed or can I work on this please?
Thanks
Vinoth Kannan

@buhtz
Copy link
Member

buhtz commented Dec 28, 2024

Hello vinothk-master,
thank you for your message and offer to work on this. As mentioned in the previous comment there is a PR (PullRequest) with number #1975 open for this issue. So there is someone who is working on this.

But there are several other opportunities to help with. You can improve the translation for example. You can offer your feedback about the re-design of the auto-remove dialog. Or just have a look into all the other issues. You also might want to look into our user manual and give us your idea how it should look like.

Don't hesitate to ask back.

Regards,
Christian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback needs user response, may be closed after timeout without a response GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues Logging & diagnostics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants