chore: Add snapshot path to error

[s4moore]

Added the path of the missing directory to the snapshot error message to aid in debugging for users

Close #1941

[buhtz]

Hello Samuel,
On behalf of the team, thank you for your contribution and taking the time to improve Back In Time. We appreciate it. Your PR is a good start.

As you might see in the TravisCI output, the test suite offers two failing tests which are related to each other:

• FAILED test/test_backup.py::TestBackup::test_cant_backup - AttributeError: 'Snapshots' object has no attribute 'snapshotsFullPath'
• snapshots.py:832:50: E1101: Instance of 'Snapshots' has no 'snapshotsFullPath' member (no-member)

We recommend to run BIT and its test suite on your local system before submitting a PR. In this case you would might have seen these errors first.

I am sure you will find a solution for these error messages. Don't hesitate to ask if you need more assistance.

Regards,
Christian

[s4moore]

Hello Christian,

Thank you for for your patience. I have updated the code to pull the snapshotsFullPath from the config instance.

I have run the test suite and there are no issues aside from some unrelated warnings. Please let me know if all okay.

Thanks,
Sam

[buhtz]

Hello Samuel,
thank you for fixing this.
I just added minor modifications regarding to our translation team. The code might be ugly but separating the translatable stings this way makes the job easier for our translators.

Regards,
Christian

[s4moore]

Okay great, sorry it's my first time working with translators.. So is that all done then? Is there anything else I need to do? (It's also my first time contributing 😬 )

I was thinking to try to solve "Highlight and report non-existent include directories #1910" next unless you have a better suggestion?

[buhtz]

Okay great, sorry it's my first time working with translators..

No need to be sorry. Dealing with translators and their strings is not easy and need a lot of experience including trail and error. I would not expect a contributor to know things like this.

So is that all done then? Is there anything else I need to do? (It's also my first time contributing 😬 )

No, everything is fine. You might see the blue check mark and "1 approval". This is my mark that your PR is fine and ready to merge. I also added the label "PR: Merge after creative break". that means the same. We usually wait some days before merging even if the PR seems to be finished. It is often a good idea to sleep over it one night or more no matter how simple a PR looks like.

To find out how we usually tread PRs please read
"What happens after you opened a PullRequest (PR)?".

I was thinking to try to solve "Highlight and report non-existent include directories #1910" next unless you have a better suggestion?

Mhm... Dealing with GUI stuff is not easy because the code base "smells" and is not well organized.

What is your native language? You might want to contribute translations?

Maybe #1105, #1018

[s4moore]

My native language is English so I guess that will not be too much help but let me know if I'm wrong on that...

I will take a look at #1105

[buhtz]

My native language is English so I guess that will not be too much help but let me know if I'm wrong on that...

Ah, OK. Just let me know if you find English that could be improved. Open an issue for this or directly edit the sources and provide the correction with an PR.

I will take a look at #1105

Good choice I think.