feat: Check if Include folders/files do exists (in case they are removed)

[rafaelhdr]

Solution b) when start taking a snapshot the include list should be checked of existence first and warn about missings.

reference: #1586

[rafaelhdr]

This is not complete yet, but if possible I would like some feedback before finishing it.

Are the messages good? And I am wondering if the qt warning is ok (it is asking a confirmation before continuing instead of just warning).

And I didn't implement a) for no big reason. I am still getting familiar with the code and b) was something that was more clear for me. I could try a) in a future PR.

And how you normally do translations? I was planning to translate all other languages using some automated tool (Copilot) but I wanted to confirm how you guys do it normally...

[buhtz]

Dear Rafael,
Awesome! Thank you for this next contribution.

I added some comments and suggestions to the code. I am not sure about the whole solution. I would suggest to further discuss it in the related issue #1586.

I will set the PR into Draft mode to state the the solution is not finished.

Best,
Christian

[rafaelhdr]

I appreciate a lot for the review. It clarified a lot of questions and taught me some good lessons (I would never have thought about RTL issues on translations). And I am happy about not use the camel case :)

I will do the fixes from the review and wait for any suggestion in the original issue.

Thank you very much 🙏

[buhtz]

Does anyone know how to trigger the systray-icon message-bubbles via BIT?

I tried with "Snapshot.setTakeSnapshotMessage(1, 'FOO BAR')" but without success. This message appears in the status bar of the main window.

[buhtz]

I would never have thought about RTL issues on translations

Me neither. When I started to work on the translation task I thougt it is easy. I learned things like that from translators and the community around them while trying to attract translators to BIT.

[buhtz]

Hello,
Just for your information. I do plan the next release (1.6.0) before Christmas.

How is your schedule? Can I plan your PR for this release (1.6.0) or for the release after it (1.6.1)?

Regards,
Christian

[rafaelhdr]

Hello

I think it would be great :)

But I am very new here (this is my second Pull Request in the project). It would be great to have someone with more experience and I am available to do any fix.

[buhtz]

OK, I checked the old review comments.
Now you should see only four pending/open review comments added by me.
You can use the "Commit suggestion" button if you want.

About aryoda's review: I would say all comments from him are solved. But I am not able to "accept" the the changes to his review on the GitHub interface. I can only click "dismiss review", which I don't want to. ;) So just treat his comments as solved.

I also updated your branch to the latest dev version. So make sure you also update your local branch at your working machine.

I would like to do some more manual tests before merging.

Let me know if you have questions or if I can be of assistance.

[buhtz]

Hello Rafael,
can you give me a ping please. 🔔 What are your plans with this PR?

I suggest you to update your local branch to the latest dev version and integrate that into your PR.

1. Go to your own "rafaelhdr:backintime" fork at GitHub. Click on "Sync fork".
2. Go to your local machine and checkout the "dev" branch.
3. Run git fetch --prune --all.
4. Run git pull.
5. Checkout your branch check-included-do-exists.
6. Run git pull.
7. Merge dev into your branch via git merge dev.
8. Resolve merge conflicts if they are there. Don't worry, we can fix them later if somethings goes wrong.
9. Push it to this PR after committing it via git push.

As an alternative, I am also able to do the merging and conflict resolving on my side. Let me know.

[rafaelhdr]

Hello Sorry. End of the year I was so busy that I couldn't give proper attention. Right now I am on vacation, but I believe I can do the fixes in the beginning of January (around 5th of January) And thank you for all your help :)

…

On Sun, Dec 29, 2024, 09:49 Christian Buhtz ***@***.***> wrote: Hello Rafael, can you give me a ping please. 🔔 What are your plans with this PR? I suggest you to update your local branch to the latest dev version and integrate that into your PR. 1. Go to your own "rafaelhdr:backintime" fork at GitHub. Click on "Sync fork". 2. Go to your local machine and checkout the "dev" branch. 3. Run git fetch --prune --all. 4. Run git pull. 5. Checkout your branch check-included-do-exists. 6. Run git pull. 7. Merge dev into your branch via git merge dev. 8. Resolve merge conflicts if they are there. Don't worry, we can fix them later if somethings goes wrong. 9. Push it to this PR after committing it via git push. — Reply to this email directly, view it on GitHub <#1718 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIOX3IKHLFWLYEXFBSTLDD2H7ASLAVCNFSM6AAAAABHOQ23LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGY3DSOBTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[buhtz]

Great to hear. Don't feel rushed. I just want to know if you are still alive. Take your time.
Have a nice vacation.

[rafaelhdr]

Thank you. I just made latest fixes from review. I think it is ready again for review.

And I appreciate an extra manual review on it 🙏

[buhtz]

The format() need to be outside of the translatable string.

# Problematic code
_('foo {val}'.format(val='bar'))

# Good code
_('foo {val}').format(val='bar')

Don't worry, this translation stuff is complex.

Suggested change

	msg = _('The following directories are missing: {dirs} Do you want to proceed?'.format(
	dirs=f'\n{msg_missing}\n\n'))
	msg = _('The following directories are missing: {dirs} Do you want to proceed?').format(
	dirs=f'\n{msg_missing}\n\n')

[buhtz]

Thank you for your work. I commented just one minor suggestion.

After that I will test it on my machine.

[buhtz]

You can move this entry up to the first section in the changelog.