feat: Add local gocryptfs support

[daviewales]

Blocked by

• refactor: Separate code about Manage profile dialog #1865

This is a rebase of Germar Reitze's gocrypt branch on the latest dev branch.

It seems to work, so I thought we should try to merge it as a base for future gocryptfs work.

I've tested backing up a test file, deleting it, then restoring it.

Related to #1734.

[buhtz]

Wow that is a big step. Awesome!

Do we need the latest GoCryptFS when running TavisCI? Are there known Issues with gocryptfs from the Ubuntu repos?

[daviewales]

I suspect that we don't need the latest version. I tested with the version in the latest Linux Mint, and it seemed to work.

[daviewales]

The code fetching the latest version was already in Germar's original branch. I haven't made many changes here, other than fixing merge conflicts.

[buhtz]

Please let me know if you prefer me to solve this merge conflicts.

[daviewales]

I'll do another rebase, and switch Travis to fetch the packaged version of gocryptfs rather than the latest release while I'm at it.

[daviewales]

I've rebased on the latest dev.
I also added a quick patch to the qt/configure script to include the new qt/manageprofiles directory when installing.

I confirmed that I can still backup a file, delete it, then restore it.

[buhtz]

When my refactoring work on the manage profiles dialog is finished I think about a release candidate and release 1.5.3.
After this we can merge your PR, after intense testing of course, and later release it as 1.6.0 somewhere around Christmas or New Year.

[buhtz]

FYI: I do plan a 1.5.3 release in the near future. After that release I would target your PR for a 1.6.0 release.

[daviewales]

I'll apply the suggestions above when I get a chance. There are also a few lint errors, so I'll fix those up too.

[daviewales]

The remaining lint errors are because there is similarity between the encfs and gocryptfs modules... Perhaps this can be ignored?

[buhtz]

The remaining lint errors are because there is similarity between the encfs and gocryptfs modules... Perhaps this can be ignored?

Usually I would say "no" and recommend to create a base class to avoid code duplication. But we will remove encfs, so I see no problem to add an ignore clause for pylint.

# pylint: disable=duplicate-code

Not sure if this need to be place in both files.

[daviewales]

Note to self: I need to test setting up a new gocryptfs backup from scratch. I've been tested this branch with one which is already configured.

EDIT: I've tested setting up a new backup profile from scratch, and the dialog needs some tweaking as it's missing a few inputs. I'll update it to match the EncFS local dialog.

[daviewales]

The gocryptfs functionality works. But Germar changed the mount API slightly to require mount backends to include an init_backend() method. (Was originally init(), but I changed it to avoid confusion.)

However, the branch I rebased never updated the encfs mount backends to include this method.

From my initial inspection, I think that init_backend is very similar to the existing _mount method, but it extracts the code required to setup a new backend if it is not yet configured.

[buhtz]

Great! You can add your name to the header of the files (see: SPDX-FileCopyrightText:). Decide yourself if you provide a nickname or your real name. Using email might cause spam.

I promoted that PR

• at Mastodon: https://fosstodon.org/@backintime/113803972815472192
• at gocryptfs community itself: Back In Time seeking help to announce and test its new #gocryptfs feature rfjakob/gocryptfs#889

[daviewales]

Thanks. I'll try to find time over the next week or two to update the EncFS module to use the new init_backend method. After that, I think it might be ready.

[daviewales]

I've updated EncFS with an init_backend method to match the new Mount structure in the gocryptfs branch.
It seems to work.

I've noticed one more missing feature.
EncFS would backup the EncFS configuration into the local config folder.
But currently, we don't have an equivalent backupConfig method for gocryptfs.
It should be pretty straightforward to copy the EncFS implementation so I'll try that soon.

EDIT: There's still a bug with EncFS. I'll see if I can track it down.