Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve "Auto-remove" ("Remove & Retention") GUI and its documentation #2000

Merged
merged 56 commits into from
Feb 2, 2025
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
cc92e06
x [skip ci]
buhtz Dec 25, 2024
042b676
rename auto-remove tab
buhtz Jan 2, 2025
69ab7e2
attention info label
buhtz Jan 2, 2025
ed4c665
HLineWidget
buhtz Jan 2, 2025
d2798f9
x
buhtz Jan 5, 2025
336bfc4
Merge branch 'dev' into fix/1976retention
buhtz Jan 9, 2025
4213e45
Merge branch 'dev' into fix/1976autoremove
buhtz Jan 9, 2025
6c046ed
Merge branch 'fix/1976autoremove' into fix/1976retention
buhtz Jan 9, 2025
1eb85d2
x [skip ci]
buhtz Jan 9, 2025
01f965a
remove debug code
buhtz Jan 9, 2025
3d1b337
groupbox [skip ci]
buhtz Jan 10, 2025
21b16c7
Merge branch 'dev' into fix/1976retention
buhtz Jan 12, 2025
78ea302
x
buhtz Jan 12, 2025
7986a0a
tooltips still missing
buhtz Jan 12, 2025
8604b03
renamed tab files
buhtz Jan 12, 2025
c1357f9
test RemoveOldSnapshotsDate. start here [skip ci]
buhtz Jan 13, 2025
c243d64
x
buhtz Jan 16, 2025
7b4c386
Merge branch 'dev' into fix/1976retention
buhtz Jan 19, 2025
8ffd942
doc [skip ci]
buhtz Jan 19, 2025
781ed78
doc [skip ci]
buhtz Jan 19, 2025
41f01f9
mkdocs [skip ci]
buhtz Jan 19, 2025
9dffd60
Merge branch 'dev' into fix/1976retention
buhtz Jan 21, 2025
9343bc8
x [skip ci]
buhtz Jan 22, 2025
bcf6231
Merge branch 'dev' into fix/1976retention
buhtz Jan 23, 2025
05a807e
doc
buhtz Jan 23, 2025
f491b69
x
buhtz Jan 23, 2025
5f10409
x
buhtz Jan 24, 2025
b8aa5d5
x [skip ci]
buhtz Jan 24, 2025
9d1c51b
x
buhtz Jan 25, 2025
720428b
x
buhtz Jan 26, 2025
d0dd2b1
minimize size
buhtz Jan 26, 2025
54c1297
mightBeRichText
buhtz Jan 26, 2025
b7043ff
x
buhtz Jan 26, 2025
b47f36e
x
buhtz Jan 26, 2025
ecb2c96
typos [skip ci]
buhtz Jan 26, 2025
e5f72b4
refactor open user manual
buhtz Jan 27, 2025
d6b3205
rule order lable link
buhtz Jan 27, 2025
34a8442
tooltips retention policy [skip ci]
buhtz Jan 27, 2025
a816334
tooltip typo [skip ci]
buhtz Jan 27, 2025
64cd3ec
x [skip ci]
buhtz Jan 28, 2025
2e50f0d
x
buhtz Jan 29, 2025
aa83b35
x
buhtz Jan 29, 2025
8af04b6
[skip ci]
buhtz Jan 29, 2025
37c032b
Merge branch 'dev' into fix/1976retention
buhtz Jan 30, 2025
825ce89
[skip ci]
buhtz Jan 30, 2025
2742b9a
x
buhtz Jan 31, 2025
ff5095f
retention policy finished. inode space missing
buhtz Jan 31, 2025
5aee8f1
removed deprecated smartremove unit tests
buhtz Jan 31, 2025
bb3793d
[skip ci]
buhtz Jan 31, 2025
7a0e500
rule
buhtz Jan 31, 2025
abfd15d
x
buhtz Jan 31, 2025
0a61323
x
buhtz Jan 31, 2025
1b8c01a
x
buhtz Jan 31, 2025
a875eb0
minor mods
buhtz Jan 31, 2025
efab395
Merge branch 'dev' into fix/1976retention
buhtz Feb 1, 2025
f219017
mkdocs site url [skip ci]
buhtz Feb 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typos [skip ci]
buhtz committed Jan 26, 2025
commit ecb2c969ee22e121d8b0995f5e4bb46c1e51c651
6 changes: 3 additions & 3 deletions doc/manual/src/remove_retention.md
Original file line number Diff line number Diff line change
@@ -52,10 +52,10 @@ The most recently created snapshot, in other words the freshest one, will be
retained and not deleted by any of the configured rules.

### Keep named snapshots
Beside the timestamp regulary used to identify snapshots, it is possible to
Beside the timestamp regularly used to identify snapshots, it is possible to
attach a name to it. Those named snapshots are never touched by any other
rule. It is a gurantee that they won't be removed. See [Main
Window](main-window.md) for more details about named snapshots.
rule. It is a guarantee that they won't be removed. See
[Main Window](main-window.md) for more details about named snapshots.

### Remove snapshots older than `N` Days/Weeks/Years
#### Year
2 changes: 1 addition & 1 deletion qt/app.py
Original file line number Diff line number Diff line change
@@ -789,7 +789,7 @@ def _create_main_toolbar(self):
toolbar.customContextMenuRequested.connect(
lambda point: self._context_menu_button_style(point, toolbar))

# Resore button styling for main toolbar
# Restore button styling for main toolbar
toolbar.setToolButtonStyle(
Qt.ToolButtonStyle(StateData().toolbar_button_style))

9 changes: 3 additions & 6 deletions qt/manageprofiles/tab_remove_retention.py
Original file line number Diff line number Diff line change
@@ -10,17 +10,14 @@
# This file is part of the program "Back In Time" which is released under GNU
# General Public License v2 (GPLv2). See LICENSES directory or go to
# <https://spdx.org/licenses/GPL-2.0-or-later.html>.
from PyQt6.QtWidgets import (QDialog,
from PyQt6.QtWidgets import (QCheckBox,
QDialog,
QGridLayout,
QVBoxLayout,
QHBoxLayout,
QGroupBox,
QHBoxLayout,
QLabel,
QSpinBox,
QStyle,
QCheckBox,
QSizePolicy,
QSpacerItem,
QToolTip,
QWidget)
from PyQt6.QtCore import Qt
6 changes: 3 additions & 3 deletions qt/qttools.py
Original file line number Diff line number Diff line change
@@ -126,13 +126,13 @@ def can_render(string, widget):
def might_be_richtext(txt: str) -> bool:
"""Returns `True` if the text is rich text.

Rich text is a subset of HTML used by Qt to allow text formating. The
Rich text is a subset of HTML used by Qt to allow text formatting. The
function checks if the first line (before the first `\n') does contain a
tag. A tag begins with with `<`, following by one or more characters and
close with `>`.

Qt itself does use `Qt::mightBeRichText()` internaly but this is not
availble in PyQt for unknown reasons.
Qt itself does use `Qt::mightBeRichText()` internally but this is not
available in PyQt for unknown reasons.

Args:
txt: The text to check.