Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Remove state file migration tests #2003

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented Jan 11, 2025

Some unit tests has overwritten the real state file, no matter that PyFakeFS was used.
The fake file system was not active anymore because StateData.save() is triggered at application exit (atexit module) when PyFakeFS is not active anymore.

After calculating maintenance cost and benefit the test was removed. Mocking around would have made to complex.

Fix #2001

@buhtz buhtz self-assigned this Jan 11, 2025
@buhtz buhtz added this to the 1.6.0 (upcoming release) milestone Jan 11, 2025
@buhtz buhtz added PR: Merge after creative-break Merge after creative-break (min. 1 week) and removed PR: Merge after creative-break Merge after creative-break (min. 1 week) labels Jan 11, 2025
@buhtz buhtz marked this pull request as draft January 12, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests do reset the state file
1 participant