-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Status information about all snapshot profiles #2019
base: dev
Are you sure you want to change the base?
Conversation
Looks nice in a first place. You are on the right track. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware that I updated your branch to the latest dev. So you have to update your local working branch, too.
- Please set the PR into Draft mode if it isn't finished yet. This helps me organizing.
- Added some PEP8 related suggestions.
- Feel free to add yourself into the SPDX header of backintime.py.
- Different from my first comments about it I would prefer to make human readable output the default behavior. So add
--json
as a new switch and remove--human-readable
.
The --issues
switch is not working as expected. I might misunderstand something?
$ ./backintime status --issues
usage: backintime status [-h] [--profile NAME | --profile-id ID | --issues ] [--human-readable]
backintime status: error: argument --issues: expected one argument
$ ./backintime status --profile 1 --issues
usage: backintime status [-h] [--profile NAME | --profile-id ID | --issues ] [--human-readable]
backintime status: error: argument --issues: expected one argument
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
I've commited some changes (and converted pr to draft):
I've been trying different layouts for the output and I think it looks neat now but I was wondering if I should add a --compact switch or something similar in case the user has lots of profiles, what do you think? Is there any other information you want to be displayed in the profile specific view (or the overview)? |
Looks good. There is a bug in BIT that helps you somehow. 🤣 So your json output and the log output is separated.
We can keep it that way. Re-write the logging machine, using Pythons in-build logging, is also on my list. But it is that big that I won't touch it yet. Usually I would say that your feature should somehow silence the log output. But with this BIT bug there is no need. Let's keep it simple. |
Do you have any suggestions on other data to be included or other changes to be made? Otherwise, should I start to look at incorporating this funcitonality into the gui? On a side note, thank you for including me in the list of contributors for the release candidate. Just a heads-up for possible future mentions, I recently changed my github username from mooresamuel to s4moore. |
Implemented the 'status' command to provide a snapshot of the status of all profiles.
options:
-h, --help show this help message and exit
--profile NAME a more detailed summary of the profile with the name, NAME
--profile-id ID a more detailed summary of the profile with the id, ID
--issues show only profiles with errors on most recent run or no snapshot history at all
--human-readable, -r print in human readable format
Consider adding a CHANGELOG entry.
Run "codespell" to check for typos.
Close #1018