Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Docs: add 0.16.3 #606

Merged
merged 1 commit into from
Sep 26, 2018
Merged

RPC Docs: add 0.16.3 #606

merged 1 commit into from
Sep 26, 2018

Conversation

karelbilek
Copy link
Contributor

@karelbilek karelbilek commented Sep 24, 2018

It is exactly the same as 0.16.2.

There are issues brought up here that are still relevant here - #590

I am not exactly sure if it's even a good idea to add this, since the RPC docs are exactly the same

dir=$PWD ; diff -ruN <( cd $dir/_doc/en/0.16.2 ; find . -type f | xargs sed 's/0\.16\.2/0.16.3/' ) <( cd $dir/_doc/en/0.16.3 ; find . -type f | xargs cat ) | wc -l
->
0

It is exactly the same as 0.16.2.
Copy link
Contributor

@harding harding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK b1108d7

Tested by building docs for myself on master and diffing to prove that they're identical to what's provided in this PR. Also previewed to ensure they rendered correctly.

@harding harding merged commit b1108d7 into bitcoin-core:master Sep 26, 2018
harding added a commit that referenced this pull request Sep 26, 2018
b1108d7 RPC Docs: add 0.16.3 (Karel Bilek)

Pull request description:

  It is exactly the same as 0.16.2.

  There are issues brought up here that are still relevant here - #590

  I am not exactly sure if it's even a good idea to add this, since the RPC docs are exactly the same

  `dir=$PWD ; diff -ruN <( cd $dir/_doc/en/0.16.2 ; find . -type f | xargs sed 's/0\.16\.2/0.16.3/' ) <( cd $dir/_doc/en/0.16.3 ; find . -type f | xargs cat ) | wc -l`
  ->
  `0`

Tree-SHA512: 451f3563793d4256369094d9e391bb57acdae7dcc99f403687983571d9d027112afa2aa6947353bbe8a8350a5c3996afbeb43351f1dff734570cf6d56dccf89b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants