-
Notifications
You must be signed in to change notification settings - Fork 50
Connect Receive page to WalletQmlModel and Cleanup Layouts #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The SendRecipientsListModel is owned by WalletQmlModel
This merges BitcoinAmount with SendRecipient to simplify the qml logic. By doing so, the conversions can be managed all in c++ against the satoshi member variable. Each recipient having its own BitcoinAmount allows the amounts to be saved independantly when there are multiple recipients.
Are you looking for UI feedback on this right now? One thing I noticed is that the QR code does not render for me like in your screenshot. |
Mostly just making sure things are working right now. I will be doing a UI pass with address formatting and amount formatting next and will include as much as I can to match the UI with the spec. I am interested to see what you're seeing with the QR rendering. That sounds like something is broken. |
Actually, UI feedback is great as well. I can manage Issues now so i will start collecting any comments about the UI as issues so that I can track them easier and reference and close them with new commits. |
Here's what that looks like (after pressing ![]() For other feedback, will you re-use the amount and label (Note to self) components from the send form that you're working on in #462? If so, then I don't need to give feedback on those right now. Other than the amount input and address display, here are some notes (many probably super obvious that you already know):
We also have to figure something out with the |
This PR is based on top of #462. The relevant commits start at "qml: Extract BitcoinAmountInputField from Send" so select the commits starting from there when reviewing in the "Files Changed" tab. You can shift+click the commits in the "Changes from" drop down to select a range.
This commit introduces the PaymentRequest QObject that backs the Receive form and is used to create new payment requests in the walletdb. These commits basically hook up the Receive page to the wallet to create actual payment requests and addresses.
As a part of connecting the page to the model. I also did a pass on the anchors and replaced them with Row/Column layouts.