Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation_change #1753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khadar1020
Copy link

@khadar1020 khadar1020 commented Dec 2, 2024

Description

issue: #1747

Notes to the reviewers

A documentation change as mentioned in the issue change

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@khadar1020
Copy link
Author

khadar1020 commented Dec 2, 2024

Hi @evanlinjin I hope you are doing well. I am new to Bitcoin development and just started learning and contributing I have recently participated in Google Summer Of Code and am looking forward to contributing to Bitcoin-core. I have a good knowledge in RUST.

Thank you

@LagginTimes
Copy link
Contributor

Thanks for your contribution! It looks like the issue you're addressing was already handled in #1670, which is expected to be included in BDK 1.0.0, though it might be pushed to a future release. If #1670 is delayed, there would be a strong argument for including this PR in 1.0.0.

@LagginTimes LagginTimes added the documentation Improvements or additions to documentation label Dec 2, 2024
@evanlinjin
Copy link
Member

@khadar1020 Thank you for reaching out! Can't wait to see your PoW. Unfortunately, as @LagginTimes has mentioned, this change is already done in #1670. Based on my best judgement, #1670 will be included in v1.0.

There seems to be a lack of good first issue tickets. I will work on posting more tickets in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants