fix: no Debug on Display implementations

[luisschwab]

Description

This PR removes the use of debugs on Display implemetations.

Changelog notice

• Implement Display for KeychainKind.
• Implement Display for LoadMismatch.
• Add error message for CreateWithPersistError.
• The CreateTxError::LockTime arm had requested and required inverted, now fixed.
• Remove debugs.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[coveralls]

Pull Request Test Coverage Report for Build 14539669521

Details

• 0 of 69 (0.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.6%) to 85.942%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
wallet/src/wallet/error.rs	0	3	0.0%
wallet/src/types.rs	0	5	0.0%
wallet/src/wallet/persisted.rs	0	29	0.0%
wallet/src/wallet/mod.rs	0	32	0.0%

Totals
Change from base Build 14270666930:	-0.6%
Covered Lines:	7269
Relevant Lines:	8458

---

💛 - Coveralls

[110CodingP]

nit: should we consider changing fmt::Display::fmt in the Display impls of LoadWithPersistError and FileStoreError to use write! for consistency in style?

[110CodingP]

ACK 6e521c9 (compiled the code and ran the tests)

[oleonardolima]

cACK 6e521c9

[luisschwab]

nit: should we consider changing fmt::Display::fmt in the Display impls of LoadWithPersistError and FileStoreError to use write! for consistency in style?

No, because we're using the Display implementation of the underlying types directly.

[luisschwab]

Rebased with suggestions from @ValuedMammal on changeset_info() implementation.

[ValuedMammal]

ACK 0d8d0ec

[evanlinjin]

ACK 0d8d0ec

Just a small nit.

[evanlinjin]

Nit: change signature of this to take in f: &mut fmt::Formatter instead.

Also:

• Separate out the descriptor checksums. `descriptor_checksum={}, change_descriptor_checksum={}.
• All more info: tx_count, anchor_count, block_count, etc.

[luisschwab]

What do you think @evanlinjin? cc @ValuedMammal

/// Helper function to display basic information about a [`ChangeSet`].
fn changeset_info(f: &mut fmt::Formatter<'_>, changeset: &ChangeSet) -> fmt::Result {
    let network = changeset.network
        .as_ref()
        .map_or("None".to_string(), |n| n.to_string());

    let descriptor_checksum = changeset.descriptor
        .as_ref()
        .and_then(|d| calc_checksum(&d.to_string()).ok())
        .unwrap_or_else(|| "None".to_string());

    let change_descriptor_checksum = changeset.change_descriptor
        .as_ref()
        .and_then(|d| calc_checksum(&d.to_string()).ok())
        .unwrap_or_else(|| "None".to_string());

    let tx_count = changeset.tx_graph.txs.len();

    let anchor_count = changeset.tx_graph.anchors.len();

    let block_count = if let Some(&count) = changeset.local_chain.blocks.keys().last() {
        count
    } else {
        0
    };

    writeln!(f, "")?;
    writeln!(f, "Network: {}", network)?;
    writeln!(f, "Descriptor Checksum: {}", descriptor_checksum)?;
    writeln!(f, "Change Descriptor Checksum: {}", change_descriptor_checksum)?;
    writeln!(f, "Transaction Count: {}", tx_count)?;
    writeln!(f, "Anchor Count: {}", anchor_count)?;
    writeln!(f, "Block Count: {}", block_count)?;
    Ok(())
}

Then it gets called by CreateWithPersistError like this:

impl<E: fmt::Display> fmt::Display for CreateWithPersistError<E> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            Self::Persist(err) => write!(f, "{}", err),
            Self::DataAlreadyExists(changeset) => {
                write!(f, "Cannot create wallet in a persister which already contains data: ")?;
                changeset_info(f, changeset)
            }
            Self::Descriptor(err) => {
                write!(f, "{err}")
            }
        }
    }
}