-
Notifications
You must be signed in to change notification settings - Fork 29
fix: no Debug
on Display
implementations
#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no Debug
on Display
implementations
#12
Conversation
Pull Request Test Coverage Report for Build 15148522315Details
💛 - Coveralls |
nit: should we consider changing |
ACK 6e521c9 (compiled the code and ran the tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK 6e521c9
No, because we're using the |
6e521c9
to
0ae48b1
Compare
0ae48b1
to
0d8d0ec
Compare
Rebased with suggestions from @ValuedMammal on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0d8d0ec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0d8d0ec
Just a small nit.
0d8d0ec
to
3c00f1a
Compare
Rebased to trigger CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 3c00f1a
Description
This PR removes the use of debugs on
Display
implemetations.Changelog notice
CreateTxError::LockTime
arm hadrequested
andrequired
inverted, now fixed.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing