Skip to content

fix: no Debug on Display implementations #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

luisschwab
Copy link
Member

@luisschwab luisschwab commented Apr 4, 2025

Description

This PR removes the use of debugs on Display implemetations.

Changelog notice

  • Implement Display for KeychainKind.
  • Implement Display for LoadMismatch.
  • Add error message for CreateWithPersistError.
  • The CreateTxError::LockTime arm had requested and required inverted, now fixed.
  • Remove debugs.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@coveralls
Copy link

coveralls commented Apr 4, 2025

Pull Request Test Coverage Report for Build 15148522315

Details

  • 0 of 85 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 85.332%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wallet/src/wallet/error.rs 0 3 0.0%
wallet/src/types.rs 0 5 0.0%
wallet/src/wallet/mod.rs 0 32 0.0%
wallet/src/wallet/persisted.rs 0 45 0.0%
Totals Coverage Status
Change from base Build 15144463728: -0.7%
Covered Lines: 7266
Relevant Lines: 8515

💛 - Coveralls

@110CodingP
Copy link

nit: should we consider changing fmt::Display::fmt in the Display impls of LoadWithPersistError and FileStoreError to use write! for consistency in style?

@110CodingP
Copy link

ACK 6e521c9 (compiled the code and ran the tests)

@ValuedMammal ValuedMammal moved this to Todo in BDK Wallet Apr 8, 2025
@ValuedMammal ValuedMammal added this to the 1.3.0 milestone Apr 8, 2025
@ValuedMammal ValuedMammal added the bug Something isn't working label Apr 8, 2025
@ValuedMammal ValuedMammal moved this from Todo to Needs Review in BDK Wallet Apr 8, 2025
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK 6e521c9

@luisschwab
Copy link
Member Author

nit: should we consider changing fmt::Display::fmt in the Display impls of LoadWithPersistError and FileStoreError to use write! for consistency in style?

No, because we're using the Display implementation of the underlying types directly.

@luisschwab luisschwab force-pushed the fix/no-debug-on-display-impls branch from 6e521c9 to 0ae48b1 Compare April 16, 2025 19:23
@luisschwab luisschwab force-pushed the fix/no-debug-on-display-impls branch from 0ae48b1 to 0d8d0ec Compare April 18, 2025 18:14
@luisschwab
Copy link
Member Author

Rebased with suggestions from @ValuedMammal on changeset_info() implementation.

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0d8d0ec

@ValuedMammal ValuedMammal requested review from evanlinjin and removed request for oleonardolima April 22, 2025 20:05
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0d8d0ec

Just a small nit.

@luisschwab luisschwab force-pushed the fix/no-debug-on-display-impls branch from 0d8d0ec to 3c00f1a Compare May 20, 2025 21:46
@luisschwab
Copy link
Member Author

Rebased to trigger CI.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3c00f1a

@notmandatory notmandatory merged commit 635af32 into bitcoindevkit:master May 21, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants