Skip to content

chore(deps): bump rand to 0.9.1, remove rand_core #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luisschwab
Copy link
Member

Closes #32 (or do we want to keep that open until a new release?)

Changelog

  • Bump rand to 0.9.1 and move it out of dev-dependencies.
  • Remove rand_core: only rand_core was imported, but then we would use bitcoin::key::rand.
  • Remove bitcoin::key::rand::thread_rng() in favor of rand::rng().
  • Rename thread_rng() to rng(), gen_range to random_range.
  • Import getrandom when the target is wasm32: it was necessary to create .cargo/config.toml as well (for context, see Stop forwarding getrandom's wasm features rust-random/rand#886).

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo +nightly fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@luisschwab luisschwab added the dependencies Pull requests that update a dependency file label May 25, 2025
@luisschwab luisschwab moved this to Needs Review in BDK Wallet May 25, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15243190737

Details

  • 35 of 37 (94.59%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.344%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wallet/src/keys/mod.rs 2 4 50.0%
Totals Coverage Status
Change from base Build 15166368710: 0.0%
Covered Lines: 7273
Relevant Lines: 8522

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Update bdk_wallet out of date dependencies
3 participants