Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/memcached] Set usePasswordFiles=true by default #32362

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+44 −3
Open

[bitnami/memcached] Set usePasswordFiles=true by default #32362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf62616
[bitnami/memcached] Set `usePasswordFiles=true` by default
migruiz4 Mar 7, 2025
f3687e3
Update CHANGELOG.md
Mar 7, 2025
d0fd6b6
Update README.md with readme-generator-for-helm
Mar 7, 2025
aa5659d
Merge branch 'main' into password-files-memcached
migruiz4 Mar 21, 2025
a19f334
Update CHANGELOG.md
bitnami-bot Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bitnami/memcached/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Changelog

## 7.7.1 (2025-03-19)
## 7.8.0 (2025-03-21)

* [bitnami/memcached] Release 7.7.1 ([#32526](https://github.com/bitnami/charts/pull/32526))
* [bitnami/memcached] Set `usePasswordFiles=true` by default ([#32362](https://github.com/bitnami/charts/pull/32362))

## <small>7.7.1 (2025-03-19)</small>

* [bitnami/*] Add tanzuCategory annotation (#32409) ([a8fba5c](https://github.com/bitnami/charts/commit/a8fba5cb01f6f4464ca7f69c50b0fbe97d837a95)), closes [#32409](https://github.com/bitnami/charts/issues/32409)
* [bitnami/memcached] Release 7.7.1 (#32526) ([8d5d1bf](https://github.com/bitnami/charts/commit/8d5d1bfdb67a25630b430d06dc0e1caca6f9f043)), closes [#32526](https://github.com/bitnami/charts/issues/32526)

## 7.7.0 (2025-03-12)

Expand Down
2 changes: 1 addition & 1 deletion bitnami/memcached/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ maintainers:
name: memcached
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/memcached
version: 7.7.1
version: 7.8.0
1 change: 1 addition & 0 deletions bitnami/memcached/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ If you encounter errors when working with persistent volumes, refer to our [trou
| `auth.username` | Memcached admin user | `""` |
| `auth.password` | Memcached admin password | `""` |
| `auth.existingPasswordSecret` | Existing secret with Memcached credentials (must contain a value for `memcached-password` key) | `""` |
| `auth.usePasswordFiles` | Mount credentials as files instead of using environment variables | `true` |
| `command` | Override default container command (useful when using custom images) | `[]` |
| `args` | Override default container args (useful when using custom images) | `[]` |
| `extraEnvVars` | Array with extra environment variables to add to Memcached nodes | `[]` |
Expand Down
16 changes: 16 additions & 0 deletions bitnami/memcached/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,17 @@ spec:
{{- if .Values.auth.enabled }}
- name: MEMCACHED_USERNAME
value: {{ .Values.auth.username | quote }}
{{- if .Values.auth.usePasswordFiles }}
- name: MEMCACHED_PASSWORD_FILE
value: "/opt/bitnami/memcached/secrets/memcached-password"
{{- else }}
- name: MEMCACHED_PASSWORD
valueFrom:
secretKeyRef:
name: {{ template "memcached.secretPasswordName" . }}
key: memcached-password
{{- end }}
{{- end }}
{{- if .Values.extraEnvVars }}
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }}
{{- end }}
Expand Down Expand Up @@ -162,6 +167,10 @@ spec:
- name: empty-dir
mountPath: /tmp
subPath: tmp-dir
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: memcached-secrets
mountPath: /opt/bitnami/memcached/secrets
{{- end }}
{{- if .Values.extraVolumeMounts }}
{{- include "common.tplvalues.render" ( dict "value" .Values.extraVolumeMounts "context" $ ) | nindent 12 }}
{{- end }}
Expand Down Expand Up @@ -222,6 +231,13 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: memcached-secrets
projected:
sources:
- secret:
name: {{ include "memcached.secretPasswordName" . }}
{{- end }}
{{- if .Values.extraVolumes }}
{{- include "common.tplvalues.render" (dict "value" .Values.extraVolumes "context" $) | nindent 8 }}
{{- end }}
Expand Down
16 changes: 16 additions & 0 deletions bitnami/memcached/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,17 @@ spec:
{{- if .Values.auth.enabled }}
- name: MEMCACHED_USERNAME
value: {{ .Values.auth.username | quote }}
{{- if .Values.auth.usePasswordFiles }}
- name: MEMCACHED_PASSWORD_FILE
value: "/opt/bitnami/memcached/secrets/memcached-password"
{{- else }}
- name: MEMCACHED_PASSWORD
valueFrom:
secretKeyRef:
name: {{ template "memcached.secretPasswordName" . }}
key: memcached-password
{{- end }}
{{- end }}
{{- if .Values.extraEnvVars }}
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }}
{{- end }}
Expand Down Expand Up @@ -215,6 +220,10 @@ spec:
- name: empty-dir
mountPath: /tmp
subPath: tmp-dir
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: memcached-secrets
mountPath: /opt/bitnami/memcached/secrets
{{- end }}
{{- if .Values.extraVolumeMounts }}
{{- include "common.tplvalues.render" ( dict "value" .Values.extraVolumeMounts "context" $ ) | nindent 12 }}
{{- end }}
Expand Down Expand Up @@ -269,6 +278,13 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: memcached-secrets
projected:
sources:
- secret:
name: {{ include "memcached.secretPasswordName" . }}
{{- end }}
{{- if .Values.extraVolumes }}
{{- include "common.tplvalues.render" (dict "value" .Values.extraVolumes "context" $) | nindent 8 }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions bitnami/memcached/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ auth:
## @param auth.existingPasswordSecret Existing secret with Memcached credentials (must contain a value for `memcached-password` key)
##
existingPasswordSecret: ""
## @param auth.usePasswordFiles Mount credentials as files instead of using environment variables
##
usePasswordFiles: true
## @param command Override default container command (useful when using custom images)
##
command: []
Expand Down
Loading