Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/nginx] Add resources to git-clone-repository initcontainer #32530

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

itd-loibl
Copy link
Contributor

Description of the change

The init container git-clone-repository is missing a possibility to configure the ressources.

Benefits

This change fixes deployment failures in scenarios where resource limits are required.

Possible drawbacks

As we use the already defined resource constraints from the git-repo-syncer container, they may not fit the needs for the initial clone.

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added nginx triage Triage is needed labels Mar 20, 2025
@github-actions github-actions bot requested a review from carrodher March 20, 2025 09:57
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@itd-loibl itd-loibl force-pushed the nginx-git-init-add-resource branch from 2ed1018 to 08b5194 Compare March 20, 2025 18:29
Signed-off-by: Bitnami Bot <[email protected]>
@itd-loibl
Copy link
Contributor Author

Thanks for the reminder. I changed the commit message.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Mar 21, 2025
@github-actions github-actions bot removed the triage Triage is needed label Mar 21, 2025
@github-actions github-actions bot removed the request for review from carrodher March 21, 2025 08:05
@github-actions github-actions bot requested a review from juan131 March 21, 2025 08:05
Signed-off-by: Bitnami Bot <[email protected]>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the contribution! LGTM

@juan131 juan131 merged commit 4c795a8 into bitnami:main Mar 25, 2025
10 checks passed
@itd-loibl itd-loibl deleted the nginx-git-init-add-resource branch March 25, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nginx solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants