-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mysqldump master database #55126
Fix mysqldump master database #55126
Conversation
@michel-silva Many thanks for the fix. I tested it again and I can confirm all the issues mentioned here, are solved. |
c6d1bd5
to
475de9f
Compare
Hi @michel-silva, So sorry for the mess, I completely missed this case. Could you resolve the comflicts? Let's merge this! |
Hi @aoterolorenzo, Don't worry. I will resolve the conflicts today and let you know. Thank for your reply. |
0267b41
to
c769f2a
Compare
@aoterolorenzo The conflicts are solved. Could you check please? |
afe7c54
to
180d849
Compare
Signed-off-by: Michel Silva <[email protected]>
Signed-off-by: Michel Silva <[email protected]>
180d849
to
e41d075
Compare
@aoterolorenzo I updated the PR.. Could you check please? |
Hi @michel-silva, Sorry for the delay again: We have been performing several breaking changes for the containers, making debian-12 the default distro for all our containers in automated batches so I just preferred to wait to merge this one, since our internal pipelines auto-generate all the scripts (so acutally I have to reproduce and propose this fix in our internal system, to avoid the pipelines tread down this changes). Please, let me see if I myself can solve the conflicts, and set up the internal code proposal. I will be back to you later |
The fix is failing due to a linter problem in our internal systems:
I'll try to fix it in your branch directly. Will be back later. |
Signed-off-by: Alberto Otero Lorenzo <[email protected]>
5f4d5d2
to
e733644
Compare
Hi @aoterolorenzo, This time was me that delay. Sorry, I was working on a urgent issue. Thank you for resolve the linter problem and merge the PR. |
Description of the change
This PR #54038 adds the functionality to dump master database when missing binary files. Its a solution to this issue #54028.
But, was checked that when the number of slaves was increased, the replication broken.
This new PR fixes this issue, that occurs when increasing the number of slaves.