Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysqldump master database #55126

Merged

Conversation

michel-silva
Copy link
Contributor

@michel-silva michel-silva commented Jan 20, 2024

Description of the change

This PR #54038 adds the functionality to dump master database when missing binary files. Its a solution to this issue #54028.

But, was checked that when the number of slaves was increased, the replication broken.

This new PR fixes this issue, that occurs when increasing the number of slaves.

@github-actions github-actions bot added mysql triage Triage is needed labels Jan 20, 2024
@github-actions github-actions bot requested a review from carrodher January 20, 2024 02:44
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 20, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jan 20, 2024
@github-actions github-actions bot removed the request for review from carrodher January 20, 2024 18:04
@mostafa-rz
Copy link

mostafa-rz commented Jan 26, 2024

@michel-silva Many thanks for the fix. I tested it again and I can confirm all the issues mentioned here, are solved.

@michel-silva michel-silva force-pushed the fix-mysqldump-master-database branch 3 times, most recently from c6d1bd5 to 475de9f Compare February 7, 2024 21:34
@aoterolorenzo
Copy link
Contributor

Hi @michel-silva,

So sorry for the mess, I completely missed this case. Could you resolve the comflicts? Let's merge this!

@michel-silva
Copy link
Contributor Author

Hi @aoterolorenzo,

Don't worry. I will resolve the conflicts today and let you know.

Thank for your reply.

@michel-silva michel-silva force-pushed the fix-mysqldump-master-database branch from 0267b41 to c769f2a Compare February 15, 2024 16:12
@michel-silva
Copy link
Contributor Author

@aoterolorenzo The conflicts are solved. Could you check please?

@michel-silva michel-silva force-pushed the fix-mysqldump-master-database branch from afe7c54 to 180d849 Compare February 15, 2024 17:16
Signed-off-by: Michel Silva <[email protected]>
Signed-off-by: Michel Silva <[email protected]>
@michel-silva michel-silva force-pushed the fix-mysqldump-master-database branch from 180d849 to e41d075 Compare February 15, 2024 17:17
@michel-silva
Copy link
Contributor Author

michel-silva commented Feb 17, 2024

@aoterolorenzo I updated the PR.. Could you check please?

@aoterolorenzo
Copy link
Contributor

Hi @michel-silva,

Sorry for the delay again: We have been performing several breaking changes for the containers, making debian-12 the default distro for all our containers in automated batches so I just preferred to wait to merge this one, since our internal pipelines auto-generate all the scripts (so acutally I have to reproduce and propose this fix in our internal system, to avoid the pipelines tread down this changes). Please, let me see if I myself can solve the conflicts, and set up the internal code proposal. I will be back to you later

@aoterolorenzo
Copy link
Contributor

The fix is failing due to a linter problem in our internal systems:

libmysql.sh:197:43: warning: Quote this to prevent word splitting. [SC2046]

I'll try to fix it in your branch directly. Will be back later.

Signed-off-by: Alberto Otero Lorenzo <[email protected]>
@aoterolorenzo aoterolorenzo force-pushed the fix-mysqldump-master-database branch from 5f4d5d2 to e733644 Compare February 26, 2024 12:35
@aoterolorenzo aoterolorenzo merged commit 4f52344 into bitnami:main Feb 26, 2024
10 checks passed
@michel-silva
Copy link
Contributor Author

Hi @aoterolorenzo,

This time was me that delay. Sorry, I was working on a urgent issue.

Thank you for resolve the linter problem and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysql solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants