-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql-repmgr] Delay custom pg_hba.conf injection #73570
[bitnami/postgresql-repmgr] Delay custom pg_hba.conf injection #73570
Conversation
Signed-off-by: Yukha Dharmeswara <[email protected]>
3cc1fc8
to
fc7abeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the late response @yukha-dw, could you please take a look at my comments?
bitnami/postgresql-repmgr/12/debian-12/rootfs/opt/bitnami/scripts/librepmgr.sh
Outdated
Show resolved
Hide resolved
bitnami/postgresql-repmgr/12/debian-12/rootfs/opt/bitnami/scripts/librepmgr.sh
Outdated
Show resolved
Hide resolved
…to `POSTGRESQL_MOUNTED_CONF_DIR` Co-authored-by: Miguel Ruiz <[email protected]> Signed-off-by: Yukha Dharmeswara <[email protected]>
Signed-off-by: Yukha Dharmeswara <[email protected]>
4482f88
to
ed06a96
Compare
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
up |
This PR seems like has been superseded by #75333. I haven't rigorously test it, but I think we can safely close this one |
Description of the change
This container applies custom
pg_hba.conf
right before initialization process. This will cause an issue when we set security onpg_hba.conf
. What this PR does is delaying custompg_hba.conf
injection untilpostgresql_initialize
has been executed just likeREPMGR_PGHBA_TRUST_ALL=no
did to replacetrust
withmd5
here:containers/bitnami/postgresql-repmgr/16/debian-12/rootfs/opt/bitnami/scripts/librepmgr.sh
Lines 865 to 867 in 2de4377
Benefits
Let user to customize
pg_hba.conf
without breaking initialization process, example:Possible drawbacks
Other logic still able to break initialization process
Applicable issues
Additional information
If we want to adapt this PR to
bitnami/postgresql
, I think we should refactor these lines:containers/bitnami/postgresql/17/debian-12/rootfs/opt/bitnami/scripts/libpostgresql.sh
Lines 610 to 613 in 56c51a6
containers/bitnami/postgresql/17/debian-12/rootfs/opt/bitnami/scripts/postgresql/setup.sh
Lines 45 to 49 in 56c51a6