Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] Issue 77295 Enable native recovery with flag/env var #77502

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FuxMak
Copy link

@FuxMak FuxMak commented Feb 14, 2025

Description of the change

Adds the feature flag/environment variable POSTGRESQL_PERFORM_RESTORE to the initialization scripts of the container.

Adjusted files:

  • "libpostgresql.sh" - Adjusted "postgresql_clean_from_restart" function to skip recovery.signal if flag is set
  • "postgresql-env.sh" - Added new environment variable/flag incl. default value
  • "README.md" - Added reference to the new environment variable/flag

Benefits

When this is set, it removes the recovery.signal file from the cleanup process, which allows an administrator to use PostgreSQL native recovery mechanisms. Due to the default being

Possible drawbacks

Due to the default value and robust handling using the is_boolean_yes function, no side-effect shall occur if the environment variable is not set.

Applicable issues

Additional information

@FuxMak FuxMak changed the title 77295 feature enable recovery [bitnami/postgresql] Issue 77295 Enable native recovery with flag/env var Feb 15, 2025
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Feb 17, 2025
@github-actions github-actions bot removed the triage Triage is needed label Feb 17, 2025
@github-actions github-actions bot removed the request for review from javsalgar February 17, 2025 09:20
@github-actions github-actions bot requested a review from migruiz4 February 17, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress postgresql verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql] Feature Request: Allow recovery by feature flag
3 participants