Only push images from bitnami/minideb repository #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot the DCO/Signed-off-by tags in my original commits, that should be fixed in the updated commit. |
|
Thanks for creating this PR. Please, note it is needed to sign the commits. Your signature certifies that you wrote the patch or otherwise have the right to contribute the material. You can find more info about this topic, in the “Sign your work” section from the contributing guidelines. In this link you can find more info about how to fix the current issue |
Make it so that only builds triggered by the `bitnami/minideb` repository will attempt to push images (because it is the only repository that has access to the required secrets). This will prevent builds in forked repositories that don't have access to the secrets from failing. Signed-off-by: John Kristensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that only builds triggered by the
bitnami/minidebrepository will attempt to push images (because it is the only repository that has access to the required secrets). This will prevent builds in forked repositories that don't have access to the secrets from failing.