Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian 12 bookworm #149

Merged
merged 4 commits into from
Jun 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build/action.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
inputs:
dist:
description: 'Dist to build'
default: 'bullseye'
default: 'bookworm'
platform:
description: 'Platform to build'
default: 'amd64'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
- cron: '0 0 * * *'
env:
BASENAME: bitnami/minideb
LATEST: bullseye
LATEST: bookworm
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
# This workflow contains a single job called "build"
Expand All @@ -41,7 +41,7 @@ jobs:
needs: [ shellcheck ]
strategy:
matrix:
dist: [buster, bullseye]
dist: [buster, bullseye, bookworm]
arch: [amd64, arm64]

name: Build ${{ matrix.dist }} on ${{ matrix.arch }}
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
- uses: actions/checkout@v3
- name: Push Manifests
run: |
DISTS="buster bullseye latest" bash pushmanifest
DISTS="buster bullseye bookworm latest" bash pushmanifest
# If the CI Pipeline does not succeed we should notify the interested agents
slack-notif:
Expand Down
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ $ docker run --rm -it bitnami/minideb:latest

There are [tags](https://hub.docker.com/r/bitnami/minideb/tags/) for the different Debian releases.
```
$ docker run --rm -it bitnami/minideb:bullseye
$ docker run --rm -it bitnami/minideb:bookworm
```

The images are built daily and have the security release enabled, so will contain any security updates released more than 24 hours ago.

You can also use the images as a base for your own `Dockerfile`:
```
FROM bitnami/minideb:bullseye
FROM bitnami/minideb:bookworm
```

# Why use Minideb
Expand Down Expand Up @@ -62,28 +62,28 @@ We provide a Makefile to help you build Minideb locally. It should be run on a D
$ sudo make
```
To build an individual release (buster or bullseye)
To build an individual release (buster, bullseye or bookworm)
```
$ sudo make bullseye
$ sudo make bookworm
```
To test the resulting image:
```
$ sudo make test-bullseye
$ sudo make test-bookworm
```
## Building Minideb for foreign architecture
Make commands shown above will build an image for the architecture you are currently working on.
To build an image for a foreign architecture (for example to build a multiarch image), we provide a
simple script which run a QEMU instance for the target architecture and build the image inside it.
To build and test a bullseye image for arm64:
To build and test a bookworm image for arm64:
```
$ ./qemu_build bullseye arm64
$ ./qemu_build bookworm arm64
```
The image will be then imported locally through the docker cli with `$distribution-$architecture` tag
(example: `bitnami/minideb:bullseye-arm64`)
(example: `bitnami/minideb:bookworm-arm64`)
Current limitations of `qemu_build` script:
Expand Down
1 change: 1 addition & 0 deletions buildall
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ arch=${1:-"amd64 arm64"}

dist="buster
bullseye
bookworm
"
for a in $arch; do
for i in $dist; do
Expand Down
1 change: 1 addition & 0 deletions debootstrap/bookworm
12 changes: 8 additions & 4 deletions mkimage
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,18 @@ fi
rootfs_chroot bash debootstrap/debootstrap --second-stage

repo_url="http://deb.debian.org/debian"
sec_repo_url="http://security.debian.org/debian-security"
sec_repo_url_1="${repo_url}-security"
sec_repo_url_2="http://security.debian.org/debian-security"

echo -e "deb ${repo_url} $DIST main" > "$rootfsDir/etc/apt/sources.list"
if [ "$DIST" == "bullseye" ]; then
if [ "$DIST" == "bookworm" ]; then
echo "deb ${repo_url} $DIST-updates main" >> "$rootfsDir/etc/apt/sources.list"
echo "deb ${sec_repo_url} $DIST-security main" >> "$rootfsDir/etc/apt/sources.list"
echo "deb ${sec_repo_url_1} $DIST-security main" >> "$rootfsDir/etc/apt/sources.list"
elif [ "$DIST" == "bullseye" ]; then
echo "deb ${repo_url} $DIST-updates main" >> "$rootfsDir/etc/apt/sources.list"
echo "deb ${sec_repo_url_2} $DIST-security main" >> "$rootfsDir/etc/apt/sources.list"
elif [ "$DIST" == "buster" ]; then
echo "deb ${sec_repo_url} $DIST/updates main" >> "$rootfsDir/etc/apt/sources.list"
echo "deb ${sec_repo_url_2} $DIST/updates main" >> "$rootfsDir/etc/apt/sources.list"
fi

rootfs_chroot apt-get update
Expand Down
3 changes: 2 additions & 1 deletion pushall
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ set -o pipefail

DISTS="buster
bullseye
bookworm
"
LATEST=bullseye
LATEST=bookworm
BASENAME=bitnami/minideb

if [ -n "${DOCKER_PASSWORD:-}" ]; then
Expand Down
1 change: 1 addition & 0 deletions pushmanifest
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ set -o pipefail

DISTS=${DISTS:-"buster
bullseye
bookworm
latest
"}

Expand Down