BEV-111 Use service param value for limiting rows fetched #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ole-v-v
commented
Aug 1, 2025
| * @param model The model for the restriction for the extraction from the database. | ||
| * @param dbConnector The connector to the database, where the audit trails are to be extracted. | ||
| */ | ||
| public AuditDatabaseExtractor(ExtractModel model, DBConnector dbConnector) { |
There was a problem hiding this comment.
ExtractModel isn’t visible outside the package, so no one could benefit from this constructor being public.
ole-v-v
commented
Aug 1, 2025
| private List<Object> extractArgumentsFromModel() { | ||
| return Stream.of(model.getFileID(), model.getCollectionID(), model.getContributorID(), | ||
| model.getMinSeqNumber(), model.getMaxSeqNumber(), model.getActorName(), | ||
| model.getOperation() == null ? null : model.getOperation().toString(), |
There was a problem hiding this comment.
Not completely sure here. The method is much terser now, but these lines aren’t beautiful, so is it worth it? I generally clearly prefer readable code over short code.
Thommelise
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Am i reading this right, that you are setting maxAuditTrails to 10.000? :)
There was a problem hiding this comment.
I am. It was unlimited before, so it should perform the same (or better if there are really more than 10 000 rows).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions from my code review.
maxResultsparameter provided in the service call to limit number of audit trails fetched from database.