Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbo.Installation.LastActivityDate column for all providers #5060

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

addisonbeck
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.07%. Comparing base (fae8692) to head (aa8a379).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...rastructure.EntityFramework/Models/Installation.cs 80.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5060      +/-   ##
==========================================
- Coverage   43.09%   43.07%   -0.03%     
==========================================
  Files        1414     1417       +3     
  Lines       64808    64852      +44     
  Branches     5925     5927       +2     
==========================================
+ Hits        27929    27934       +5     
- Misses      35645    35684      +39     
  Partials     1234     1234              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 18c1f154-9ad3-462b-93e0-cc9f8b652a9f

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant