[PM-10600] Push notification with full notification center content #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5086 +/- ##
=======================================
Coverage 44.43% 44.43%
=======================================
Files 1500 1500
Lines 69521 69546 +25
Branches 6262 6262
=======================================
+ Hits 30890 30905 +15
- Misses 37304 37314 +10
Partials 1327 1327 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
mzieniukbw
changed the title
withinfocus
changed the title
withinfocus
previously approved these changes
Nov 26, 2024
Thomas-Avery
approved these changes
Nov 26, 2024
test/Core.Test/NotificationHub/NotificationHubPushNotificationServiceTests.cs
Show resolved
Hide resolved
This was referenced Nov 26, 2024
…ifications We only register devices for organization push notifications when the organization is being created. This does not work, since we have a use case (Notification Center) of delivering notifications to all users of organization. This fixes it, by adding the organization id tag when device registers for push notifications.
Fixed IFeatureService substitute mocking for Android tests. Added user part of organization test with organizationId tags expectation.
…ter merge conflict
mzieniukbw
force-pushed
the
km/pm-10600-full-notification-content
branch
from
9a06ab7 to
997165d
Compare
Notification Center push notification now includes all the fields.
mzieniukbw
force-pushed
the
km/pm-10600-full-notification-content
branch
from
997165d to
02e45c3
Compare
|
I had to rebase and force push on top of |
dani-garcia
previously approved these changes
Jan 16, 2025
Thomas-Avery
previously approved these changes
Jan 16, 2025
ike-kottlowski
previously approved these changes
Jan 20, 2025
mzieniukbw
dismissed stale reviews from ike-kottlowski, Thomas-Avery, dani-garcia, and withinfocus
The base branch was changed.
# Conflicts: # src/Core/Models/PushNotification.cs # src/Core/NotificationCenter/Commands/CreateNotificationCommand.cs # src/Core/NotificationHub/NotificationHubPushNotificationService.cs # src/Core/Platform/Push/Services/AzureQueuePushNotificationService.cs # src/Core/Platform/Push/Services/IPushNotificationService.cs # src/Core/Platform/Push/Services/MultiServicePushNotificationService.cs # src/Core/Platform/Push/Services/NoopPushNotificationService.cs # src/Core/Platform/Push/Services/NotificationsApiPushNotificationService.cs # src/Core/Platform/Push/Services/RelayPushNotificationService.cs # src/Notifications/HubHelpers.cs # test/Core.Test/NotificationCenter/Commands/CreateNotificationCommandTest.cs # test/Core.Test/NotificationHub/NotificationHubPushNotificationServiceTests.cs # test/Core.Test/Platform/Push/Services/AzureQueuePushNotificationServiceTests.cs # test/Core.Test/Platform/Push/Services/MultiServicePushNotificationServiceTests.cs
|
Thomas-Avery
approved these changes
Feb 12, 2025
justindbaur
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10600
This is Part 2.
See Part 1: #4923
See Part 3: #5057
📔 Objective
Notification Center push notification now includes all the fields.
The push notification have a limit of 4KB for payload (limitation of Azure Notification Hub, FCM and APNS). For notification center push notification, only
Bodyfield needs to have a max length, since other fields have deterministic max length. No other push notifications are affected.To fix this, a separate PR will follow once the API PR is merged #4852 that will have the max length of 3000 on the
Bodyfield in the request and optionally in db column too.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes