Remove association override #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evman182
force-pushed
the
eraffel/FixAssociations
branch
from
b870bb3 to
ba12d0f
Compare
|
@bkroeker Do you remember why specifying the primary key was needed like this? There's no tests that are failing, and the current implementation is causing issues for me in Rails 7.1 |
|
@evman182 Your change makes sense to me. I can't think of what use case I would have been coding for here. If possible, and if there isn't one already, can you add a spec for a table which uses a non-standard primary key? |
|
@bkroeker what scares me is that the change was made 11 years ago, so I'm afraid of what it might break: |
|
@bkroeker Are you good with the tests here? Any remaining concerns? |
bkroeker
approved these changes
Feb 20, 2024
Co-authored-by: Brent Kroeker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.