Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-64604: Merge remote-tracking branch 'origin/trinity-couchbase' into 'master' #2120

Merged
merged 4 commits into from
Dec 17, 2024
Merged

MB-64604: Merge remote-tracking branch 'origin/trinity-couchbase' into 'master' #2120

merged 4 commits into from
Dec 17, 2024

Conversation

abhinavdangeti
Copy link
Member

@abhinavdangeti abhinavdangeti commented Dec 17, 2024 •
edited
Loading 

|\
| * 5c536342 Abhi Dangeti | MB-64604: Remove unnecessary second map lookup (#2121)
| * 78cf7899 Abhi Dangeti | MB-64604: Fix interpreting scorch config: "fieldTFRCacheThreshold" (#2117)
| * 7d627b9f Aditi Ahuja | MB-64360 - Upgrade zapx v16 (#2107)

metonymic-smokey and others added 2 commits November 28, 2024 18:46
@metonymic-smokey
MB-64360 - Upgrade zapx v16 (#2107)
7d627b9 
Update zapx version.
@abhinavdangeti
MB-64604: Fix interpreting scorch config: "fieldTFRCacheThreshold" (#…
78cf789 
…2117)

+ Setting the default to 0 on account of the panics caught in the MB.
+ Firstly, refactor `FieldTFRCacheThreshold` to `fieldTFRCacheThreshold`
for _some_ naming consistency here.
+ This threshold can be used to toggle recycling of TermFieldReaders
on/off.
+ Couchbase users will have the ability to provide this setting within a
JSON payload, which when interpreted into a `map[string]interface{}`
will need to be interpreted as a `float64`.
+ Should library users set it as an `int` within the index config -
we'll honor that setting as well.
@abhinavdangeti abhinavdangeti added this to the v2.5.0 milestone Dec 17, 2024
@abhinavdangeti abhinavdangeti changed the title Merge remote-tracking branch 'origin/trinity-couchbase' into 'master' MB-64604: Merge remote-tracking branch 'origin/trinity-couchbase' into 'master' Dec 17, 2024
@abhinavdangeti
MB-64604: Merge remote-tracking branch 'origin/trinity-couchbase' int…
7d6f4ab 
…o 'master'

|\
| * 5c53634 Abhi Dangeti | MB-64604: Remove unnecessary second map lookup (#2121)
| * 78cf789 Abhi Dangeti | MB-64604: Fix interpreting scorch config: "fieldTFRCacheThreshold" (#2117)
| * 7d627b9 Aditi Ahuja | MB-64360 - Upgrade zapx v16 (#2107)
@abhinavdangeti abhinavdangeti merged commit a8d41b3 into master Dec 17, 2024
9 checks passed
@abhinavdangeti abhinavdangeti deleted the mb64604_forwardmerge branch December 17, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thejas-bhat Thejas-bhat Awaiting requested review from Thejas-bhat

@metonymic-smokey metonymic-smokey Awaiting requested review from metonymic-smokey

@CascadingRadium CascadingRadium Awaiting requested review from CascadingRadium

@Likith101 Likith101 Awaiting requested review from Likith101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavdangeti @metonymic-smokey