MB-64883: Adapt interface change for VectorIndex #302
+160
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abhinavdangeti
commented
Feb 5, 2025
abhinavdangeti
commented
- Requires: MB-64883: Change signature of VectorIndex's SearchWithFilter scorch_segment_api#50
- Change signature of SearchWithFilter to minimize work and take advantage of roaring bitmap operations.
- Change cached signature of docVecIDMap for easier usability.
- More TODOs
+ Requires: blevesearch/scorch_segment_api#50 + Change signature of SearchWithFilter to minimize work and take advantage of roaring bitmap operations. + Change cached signature of docVecIDMap for easier usability. + More TODOs
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
Likith101
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Feb 5, 2025
abhinavdangeti
commented
Feb 5, 2025
| // Ordering the retrieved centroid IDs by increasing order | ||
| // of distance i.e. decreasing order of proximity to query vector. | ||
| closestCentroidIDs, centroidDistances, _ := | ||
| vecIndex.ObtainClustersWithDistancesFromIVFIndex(qVector, eligibleCentroidIDs) |
There was a problem hiding this comment.
@metonymic-smokey I'm hoping profiling will reveal how much of time/CPU is distributed among ..
- ObtainClustersWithDistancesFromIVFIndex
- SearchClustersFromIVFIndex
| vecIDsUint32 = append(vecIDsUint32, uint32(vecID)) | ||
| } | ||
| centroidVecIDMap[centroidID].AddMany(vecIDsUint32) | ||
| // TODO: WHY NOT CACHE THIS? |
There was a problem hiding this comment.
Need to see about this.
| rv := &VecPostingsList{ | ||
| except: nil, // todo: handle the except bitmap within postings iterator. | ||
| except: nil, // TODO: handle the except bitmap within postings iterator. |
There was a problem hiding this comment.
What was this TODO about?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.