This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
1.0.0 wip edge #271
Open
LEEJUNESEOK
wants to merge
163
commits into
0.9.0
Choose a base branch
from
1.0.0-wip-edge
base: 0.9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1.0.0 wip edge #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when added multiple times for a same store view, attributes are now only joined once - fix for renderer default values
…ns <select> (left-click to go to a profile, right-click to view all the available actions)
- reworked the output of the messages block - fixed a typo preventing from copying default parameters from one profile to another
- rearranged fields in configuration windows - implemented advanced possibilities for options columns filtering - various fixes for the options sources - some code cleanup
…from the options renderer - same thing for the "Status (With Color)" custom column from the orders grid - various fixes for the custom columns with a locked renderer - little cleanup in the custom columns code - added one forgotten file (needed for togglable fieldsets)
- started reducing of cyclomatic and NPath complexities - big design and usability rework (including various improvements and new customization options) - introduced the possibility to edit the forced grid types - reworked the grid block and collection verifications for custom columns (not blocking anymore by default) - various bug fixes
- multiple various fixes
- small README.md change - fixed a warning
- improved the grid edit page - completed 1.0.0 setup file, bumped version accordingly - more code cleanup / refactoring - reduced code duplication - reduced complexity of BL_CustomGrid_Model_Grid - reduced complexity BL_CustomGrid_Model_Custom_Column_Abstract - various fixes
- various fixes
- implemented inventory columns editability - implemented the most common use cases of BL_CustomGrid_Model_Grid_Editor_Value_Config as actual methods - fixed the custom columns form - refactored a part of the BL_CustomGrid_Model_Grid_Rewriter_Abstract class - other small fixes
…void cluttering any external wrapping form with a lot of parameters, making it exceed the maximum variables limit)
… default renderer now dispatches the rendering to the new blocks depending on the field type)
…orker models - improved consistency for methods naming / comments - small fixes
mage-eag
force-pushed
the
1.0.0-wip-edge
branch
from
March 10, 2016 09:53
9789b17
to
e88b74c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I using 1.0.0 version.
Looks it has bug, Can you check it?
BL/CustomGrid/Block/Widget/Grid/Column/Renderer/Text.php
56 Line
`if (($truncationMode = $this->getColumn()->getTruncationMode())
&& ($truncationMode != self::TRUNCATION_MODE_NONE)) {
/** @var $stringHelper BL_CustomGrid_Helper_String */
$stringHelper = $this->helper('customgrid/string');
$truncationLength = (int) $this->getColumn()->getTruncationAt();
$truncationEnding = $this->getColumn()->getTruncationEnding();
$exactTruncation = (bool) $this->getColumn()->getExactTruncation();
$remainder = '';
`
$truncationLength value always 0,
$truncationEnding also empty.
It related with adding text field grid > rendering > truncation setting in catalog/product page.
$truncationMode return right value as setting,
but 'Truncate at n-th character', 'Truncate ending string' value doesn't return it.
as it result, when Truncate => yes, custom field show empty value. ( truncationLength==0, return '' )
I tested it php7 and php 5.6